Fix tools/android_stack_parser/stack and use it in skydb

sky/tools/skydb

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-import skypy.paths
 from skypy.skyserver import SkyServer
 import argparse
 import json
 import logging
 import os
 import pipes
 import requests
 import signal
+import skypy.paths
+import StringIO
 import subprocess
 import sys
 import time
 import urlparse
 
 SRC_ROOT = skypy.paths.Paths('ignored').src_root
 sys.path.insert(0, os.path.join(SRC_ROOT, 'build', 'android'))
 from pylib import android_commands
 from pylib import constants
 from pylib import forwarder
@@ skipping 286 matching lines @@
                 time.sleep(1)
 
     def logcat_command(self, args):
         TAGS = [
             'AndroidHandler',
             'MojoMain',
             'MojoShellActivity',
             'MojoShellApplication',
             'chromium',
         ]
-        subprocess.call(['adb', 'logcat', '-s'] + TAGS)
+        subprocess.call(['adb', 'logcat', '-d', '-s'] + TAGS)

[eseidel, 2015/01/13 22:58:02]

This makes skydb logcat exit immediately insetead of waiting for ctrl-C

 
     def gdb_attach_command(self, args):
         self.paths = self._create_paths_for_build_dir(self.pids['build_dir'])
         gdb_command = [
             '/usr/bin/gdb', self.paths.mojo_shell_path,
             '--eval-command', 'target remote localhost:%s' % GDB_PORT
         ]
         print " ".join(gdb_command)
         # We don't want python listenting for signals or anything, so exec
         # gdb and let it take the entire process.
         os.execv(gdb_command[0], gdb_command)
 
+    def print_crash_command(self, args):
+        logcat_cmd = ['adb', 'logcat', '-d']
+        logcat = subprocess.Popen(logcat_cmd, stdout=subprocess.PIPE)
+
+        stack_path = os.path.join(SRC_ROOT,
+            'tools', 'android_stack_parser', 'stack')
+        stack = subprocess.Popen([stack_path, '-'], stdin=logcat.stdout)
+        logcat.wait()
+        stack.wait()
+
     def main(self):
         logging.basicConfig(level=logging.INFO)
         logging.getLogger("requests").setLevel(logging.WARNING)
 
         self.pids = self._load_pid_file(PID_FILE_PATH)
 
         parser = argparse.ArgumentParser(description='Sky launcher/debugger')
         subparsers = parser.add_subparsers(help='sub-command help')
 
         start_parser = subparsers.add_parser('start',
@@ skipping 11 matching lines @@
         start_parser.set_defaults(func=self.start_command)
 
         stop_parser = subparsers.add_parser('stop',
             help=('stop sky (as listed in %s)' % PID_FILE_PATH))
         stop_parser.set_defaults(func=self.stop_command)
 
         logcat_parser = subparsers.add_parser('logcat',
             help=('dump sky-related logs from device'))
         logcat_parser.set_defaults(func=self.logcat_command)
 
+        print_crash_parser = subparsers.add_parser('print_crash',
+            help=('dump (and symbolicate) recent crash-stacks'))
+        print_crash_parser.set_defaults(func=self.print_crash_command)
+
         gdb_attach_parser = subparsers.add_parser('gdb_attach',
             help='launch gdb and attach to gdbserver launched from start --gdb')
         gdb_attach_parser.set_defaults(func=self.gdb_attach_command)
 
         self._add_basic_command(subparsers, 'trace', '/trace',
             'toggle tracing')
         self._add_basic_command(subparsers, 'reload', '/reload',
             'reload the current page')
         self._add_basic_command(subparsers, 'inspect', '/inspect',
             'stop the running sky instance')
 
         load_parser = subparsers.add_parser('load',
             help='load a new page in the currently running sky')
         load_parser.add_argument('url_or_path', type=str)
         load_parser.set_defaults(func=self.load_command)
 
         args = parser.parse_args()
         args.func(args)
 
         self._write_pid_file(PID_FILE_PATH, self.pids)
 
 
 if __name__ == '__main__':
     SkyDebugger().main()