Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 787803002: Cleanup: remove SupervisedUserService::IsChildAccount. (Closed)

Created:
6 years ago by Marc Treib
Modified:
6 years ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: remove SupervisedUserService::IsChildAccount. We now have Profile::IsChild! BUG= Committed: https://crrev.com/ad86c01a60c33e6b79c141203b7bb26696e7fed6 Cr-Commit-Position: refs/heads/master@{#307446}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 7 (2 generated)
Marc Treib
PTAL! https://codereview.chromium.org/787803002/diff/1/chrome/browser/supervised_user/supervised_user_service.h File chrome/browser/supervised_user/supervised_user_service.h (right): https://codereview.chromium.org/787803002/diff/1/chrome/browser/supervised_user/supervised_user_service.h#newcode87 chrome/browser/supervised_user/supervised_user_service.h:87: virtual bool IsChildAccount() const; Still here so I ...
6 years ago (2014-12-09 09:27:28 UTC) #2
Bernhard Bauer
LGTM Ping me when this lands, so I can update the Clank side?
6 years ago (2014-12-09 09:35:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787803002/1
6 years ago (2014-12-09 09:55:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 11:13:02 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-09 11:13:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad86c01a60c33e6b79c141203b7bb26696e7fed6
Cr-Commit-Position: refs/heads/master@{#307446}

Powered by Google App Engine
This is Rietveld 408576698