Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1535)

Unified Diff: Source/core/rendering/svg/RenderSVGResourceContainer.cpp

Issue 787563003: Fix RenderSVGResourceContainer task re-ordering bug (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove unwanted change Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/svg/RenderSVGResourceContainer.cpp
diff --git a/Source/core/rendering/svg/RenderSVGResourceContainer.cpp b/Source/core/rendering/svg/RenderSVGResourceContainer.cpp
index 53dcdfc025d55056f4f2085e3913c4470a3434ad..2f4d3fff8a5312e25470f9469603d5e9795d31da 100644
--- a/Source/core/rendering/svg/RenderSVGResourceContainer.cpp
+++ b/Source/core/rendering/svg/RenderSVGResourceContainer.cpp
@@ -225,7 +225,9 @@ void RenderSVGResourceContainer::registerResource()
StyleDifference diff;
Sami 2014/12/08 11:27:34 Looks like these two lines could go inside the if
alex clarke (OOO till 29th) 2015/01/28 16:09:58 Acknowledged.
diff.setNeedsFullLayout();
- SVGResourcesCache::clientStyleChanged(renderer, diff, renderer->style());
+ if (renderer->node() && renderer->node()->isSVGElement()) {
kouhei (in TOK) 2014/12/08 11:11:17 Please add a comment above this line that SVGPendi
alex clarke (OOO till 29th) 2015/01/28 16:09:58 Acknowledged.
+ SVGResourcesCache::clientStyleChanged(renderer, diff, renderer->style());
+ }
renderer->setNeedsLayoutAndFullPaintInvalidation();
}
}

Powered by Google App Engine
This is Rietveld 408576698