Fix RenderSVGResourceContainer task re-ordering bug

Source/core/rendering/svg/RenderSVGResourceContainer.cpp

 /*
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 205 matching lines @@
 
     // Update cached resources of pending clients.
     const SVGDocumentExtensions::SVGPendingElements::const_iterator end = clients->end();
     for (SVGDocumentExtensions::SVGPendingElements::const_iterator it = clients->begin(); it != end; ++it) {
         ASSERT((*it)->hasPendingResources());
         extensions.clearHasPendingResourcesIfPossible(*it);
         RenderObject* renderer = (*it)->renderer();
         if (!renderer)
             continue;
 
         StyleDifference diff;

[Sami, 2014/12/08 11:27:34]

Looks like these two lines could go inside the if statement too.

[alex clarke (OOO till 29th), 2015/01/28 16:09:58]

Acknowledged.

         diff.setNeedsFullLayout();
-        SVGResourcesCache::clientStyleChanged(renderer, diff, renderer->style());
+        if (renderer->node() && renderer->node()->isSVGElement()) {

[kouhei (in TOK), 2014/12/08 11:11:17]

Please add a comment above this line that SVGPendingElements may include
arbitrary element that uses CSS filter referencing SVG filter.

Nit: unneeded {}

[alex clarke (OOO till 29th), 2015/01/28 16:09:58]

Acknowledged.

+            SVGResourcesCache::clientStyleChanged(renderer, diff, renderer->style());
+        }
         renderer->setNeedsLayoutAndFullPaintInvalidation();
     }
 }
 
 static inline void removeFromCacheAndInvalidateDependencies(RenderObject* object, bool needsLayout)
 {
     ASSERT(object);
     if (SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject(object)) {
         if (RenderSVGResourceFilter* filter = resources->filter())
             filter->removeClientFromCache(object);
@@ skipping 51 matching lines @@
             // This will process the rest of the ancestors.
             toRenderSVGResourceContainer(current)->removeAllClientsFromCache();
             break;
         }
 
         current = current->parent();
     }
 }
 
 }