build/android/pylib/instrumentation/test_runner.py - Issue 787393003: Add access to read-only properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/test_runner.py

Issue 787393003: Add access to read-only properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: migrate clients to use properties Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/instrumentation/test_runner.py

diff --git a/build/android/pylib/instrumentation/test_runner.py b/build/android/pylib/instrumentation/test_runner.py

index 92d80f97f145362d66272433be5a3ccbfd0b0932..145a629972931c2af2ec72d0e5a49178ecc601ff 100644

--- a/build/android/pylib/instrumentation/test_runner.py

+++ b/build/android/pylib/instrumentation/test_runner.py

@@ -443,7 +443,7 @@ class TestRunner(base_test_runner.BaseTestRunner):

timeout = (self._GetIndividualTestTimeoutSecs(test) *

self._GetIndividualTestTimeoutScale(test) *

self.tool.GetTimeoutScale())

- if (self.device.GetProp('ro.build.version.sdk')

+ if (self.device.build_version_sdk

< constants.ANDROID_SDK_VERSION_CODES.JELLY_BEAN):

perezju 2014/12/10 13:37:34 Note how this test was actually BROKEN, comparing

jbudorick 2014/12/11 02:05:56 X( This was me. Nice catch.

timeout *= 10