build/android/pylib/instrumentation/test_jar.py - Issue 787393003: Add access to read-only properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/test_jar.py

Issue 787393003: Add access to read-only properties (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: migrate clients to use properties Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/android/pylib/instrumentation/test_jar.py

diff --git a/build/android/pylib/instrumentation/test_jar.py b/build/android/pylib/instrumentation/test_jar.py

index 4473810e6202edddbcf384ecff2cb4dbe98a1904..c3faef31f70f026c23f183def272d9354cf9c99e 100644

--- a/build/android/pylib/instrumentation/test_jar.py

+++ b/build/android/pylib/instrumentation/test_jar.py

@@ -215,12 +215,10 @@ class TestJar(object):

# Filter out any tests with SDK level requirements that don't match the set

# of attached devices.

- sdk_versions = [

- int(v) for v in

- device_utils.DeviceUtils.parallel().GetProp(

- 'ro.build.version.sdk').pGet(None)]

+ devices = device_utils.DeviceUtils.parallel()

+ min_sdk_version = min(devices.build_version_sdk.pGet(None))

perezju 2014/12/10 13:37:34 nice thing that properties also work through paral

tests = [t for t in tests

- if self._IsTestValidForSdkRange(t, min(sdk_versions))]

+ if self._IsTestValidForSdkRange(t, min_sdk_version)]

return tests