Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 787353003: Animation: Allow cubic-bezier timing inputs outside the range [0, 1] in CC (Closed)

Created:
5 years, 11 months ago by loyso (OOO)
Modified:
5 years, 11 months ago
Reviewers:
Ian Vollick, dstockwell
CC:
dstockwell, darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, Mike Lawther (Google), rjwright, shans, Steve Block, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/blink.git@0
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Animation: Allow cubic-bezier timing inputs outside the range [0, 1] in CC A blink part. Chromium part: https://codereview.chromium.org/833093002/ Support this blink change https://codereview.chromium.org/238573002 but on the compositor side. BUG=445507 R=dstockwell@chromium.org R=ajuma@chromium.org R=japhet@chromium.org TEST=ManualTests/animation/compositor-animation-steps.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188109

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -21 lines) Patch
M ManualTests/animation/compositor-animation-steps.html View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/animation/CompositorAnimations.cpp View 1 1 chunk +0 lines, -14 lines 0 comments Download
M Source/core/animation/CompositorAnimationsTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
loyso (OOO)
5 years, 11 months ago (2015-01-05 07:05:18 UTC) #1
Ian Vollick
On 2015/01/05 07:05:18, loyso wrote: lgtm once the chromium side lands.
5 years, 11 months ago (2015-01-05 15:40:03 UTC) #2
dstockwell
lgtm
5 years, 11 months ago (2015-01-06 22:20:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787353003/20001
5 years, 11 months ago (2015-01-09 02:31:54 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 03:53:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188109

Powered by Google App Engine
This is Rietveld 408576698