Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 238573002: Web Animations: Allow timing inputs outside the range [0, 1] (Closed)

Created:
6 years, 8 months ago by shans
Modified:
6 years, 7 months ago
CC:
blink-reviews, rjwright, Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@lkgr
Visibility:
Public.

Description

Web Animations: Allow timing function inputs outside the range [0, 1] FOR LINEAR TIMING FUNCTIONS the timing function is naturally extended so that output continues to equal input FOR STEP FUNCTIONS the step is clamped to the range [0, 1] FOR BEZIERS End-point gradients are used to calculate timing function results outside the range [0, 1]. There are three possibilities for the gradient at each end: (1) the closest control point is not horizontally coincident with regard to (0, 0) or (1, 1). In this case the line between the end point and the control point is tangent to the bezier at the end point. (2) the closest control point is coincident with the end point. In this case the line between the end point and the far control point is tangent to the bezier at the end point. (3) the closest control point is horizontally coincident with the end point, but vertically distinct. In this case the gradient at the end point is Infinite. However, this causes issues when interpolating. As a result, we break down to a simple case of 0 gradient under these conditions. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172821

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -7 lines) Patch
M Source/platform/animation/TimingFunction.cpp View 1 2 4 chunks +3 lines, -3 lines 0 comments Download
M Source/platform/animation/TimingFunctionTest.cpp View 1 5 chunks +15 lines, -0 lines 0 comments Download
M Source/platform/animation/UnitBezier.h View 1 3 chunks +35 lines, -2 lines 0 comments Download
M Source/platform/animation/UnitBezierTest.cpp View 1 2 1 chunk +23 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
shans
6 years, 8 months ago (2014-04-15 01:53:43 UTC) #1
alancutter (OOO until 2018)
The change description should state the behaviour being introduced here. Unit tests would be useful ...
6 years, 8 months ago (2014-04-15 03:20:25 UTC) #2
dstockwell
approach looks good
6 years, 8 months ago (2014-04-15 04:55:24 UTC) #3
shans
On 2014/04/15 04:55:24, dstockwell wrote: > approach looks good Step functions are a problem - ...
6 years, 8 months ago (2014-04-15 21:17:53 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/238573002/diff/20001/Source/platform/animation/TimingFunction.cpp File Source/platform/animation/TimingFunction.cpp (right): https://codereview.chromium.org/238573002/diff/20001/Source/platform/animation/TimingFunction.cpp#newcode95 Source/platform/animation/TimingFunction.cpp:95: return std::min(std::max(floor((m_steps * fraction) + startOffset) / m_steps, 0.0), ...
6 years, 8 months ago (2014-04-16 04:50:42 UTC) #5
shans
https://codereview.chromium.org/238573002/diff/20001/Source/platform/animation/TimingFunction.cpp File Source/platform/animation/TimingFunction.cpp (right): https://codereview.chromium.org/238573002/diff/20001/Source/platform/animation/TimingFunction.cpp#newcode95 Source/platform/animation/TimingFunction.cpp:95: return std::min(std::max(floor((m_steps * fraction) + startOffset) / m_steps, 0.0), ...
6 years, 8 months ago (2014-04-17 06:04:17 UTC) #6
dstockwell
lgtm
6 years, 8 months ago (2014-04-23 01:48:01 UTC) #7
shans
The CQ bit was checked by shans@chromium.org
6 years, 8 months ago (2014-04-27 20:06:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shans@chromium.org/238573002/40001
6 years, 8 months ago (2014-04-27 20:06:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-27 20:13:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-27 20:13:12 UTC) #11
eseidel
lgtm
6 years, 7 months ago (2014-04-28 23:15:23 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 03:18:12 UTC) #13
Message was sent while issue was closed.
Change committed as 172821

Powered by Google App Engine
This is Rietveld 408576698