Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 787343003: Remove the index of in-band tracks on the Chromium side (Closed)

Created:
6 years ago by Henrik Steen
Modified:
6 years ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the index of in-band tracks on the Chromium side Note: https://codereview.chromium.org/754963009 removes the usage of textTrackIndex() and has to be applied first. BUG=440777 R=philipj@opera.com Committed: https://crrev.com/9cce5fa8aecab7b9ece31a6f920a6746508e1f9e Cr-Commit-Position: refs/heads/master@{#308063}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M media/blink/webinbandtexttrack_impl.h View 2 chunks +1 line, -5 lines 0 comments Download
M media/blink/webinbandtexttrack_impl.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Henrik Steen
6 years ago (2014-12-10 14:38:28 UTC) #1
philipj_slow
LGTM, but I have no power :) Andrew, can you rubberstamp this? The bug explains ...
6 years ago (2014-12-10 14:55:20 UTC) #3
scherkus (not reviewing)
lgtm thanks for the patch and informative bug report!
6 years ago (2014-12-10 17:22:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787343003/1
6 years ago (2014-12-12 06:38:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/25548) linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/14026)
6 years ago (2014-12-12 06:42:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787343003/1
6 years ago (2014-12-12 07:42:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/14056) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/37043)
6 years ago (2014-12-12 07:49:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787343003/1
6 years ago (2014-12-12 08:52:11 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-12 09:35:37 UTC) #15
commit-bot: I haz the power
6 years ago (2014-12-12 09:36:25 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cce5fa8aecab7b9ece31a6f920a6746508e1f9e
Cr-Commit-Position: refs/heads/master@{#308063}

Powered by Google App Engine
This is Rietveld 408576698