Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 754963009: Do not use inbandTrackIndex() when assigning track index (Closed)

Created:
6 years ago by Henrik Steen
Modified:
6 years ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Do not use inbandTrackIndex() when assigning track index Simply append the track at the end instead. BUG=440777 R=philipj@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186964

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M Source/core/html/track/InbandTextTrack.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/InbandTextTrack.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M public/platform/WebInbandTextTrack.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Henrik Steen
6 years ago (2014-12-10 14:38:26 UTC) #1
philipj_slow
lgtm
6 years ago (2014-12-10 14:43:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754963009/1
6 years ago (2014-12-10 14:44:00 UTC) #4
philipj_slow
Can you link to the Chromium-side patch here as well?
6 years ago (2014-12-10 14:44:33 UTC) #5
Henrik Steen
On 2014/12/10 14:44:33, philipj wrote: > Can you link to the Chromium-side patch here as ...
6 years ago (2014-12-10 14:46:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/21872)
6 years ago (2014-12-10 14:47:45 UTC) #8
philipj_slow
Problem solved in https://codereview.chromium.org/794183002/ Please try again when that has landed.
6 years ago (2014-12-11 15:06:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/754963009/1
6 years ago (2014-12-11 15:39:21 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-11 16:55:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186964

Powered by Google App Engine
This is Rietveld 408576698