Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 787153002: Reland 'Do not embed constant functions in StoreTransition stub.' (Closed)

Created:
6 years ago by ulan
Modified:
6 years ago
Reviewers:
Igor Sheludko, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Reland 'Do not embed constant functions in StoreTransition stub.' BUG=v8:3629 LOG=N

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -22 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M src/ic/handler-compiler.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +4 lines, -3 lines 1 comment Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +10 lines, -3 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ulan
PTAL https://codereview.chromium.org/787153002/diff/1/src/ic/handler-compiler.cc File src/ic/handler-compiler.cc (right): https://codereview.chromium.org/787153002/diff/1/src/ic/handler-compiler.cc#newcode333 src/ic/handler-compiler.cc:333: Handle<DescriptorArray> descriptors(transition->instance_descriptors()); This is the only diff from ...
6 years ago (2014-12-09 17:30:37 UTC) #2
Igor Sheludko
lgtm
6 years ago (2014-12-09 18:00:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/787153002/1
6 years ago (2014-12-10 09:58:45 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-10 10:28:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698