Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: src/ic/arm64/handler-compiler-arm64.cc

Issue 787153002: Reland 'Do not embed constant functions in StoreTransition stub.' (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 Register map_reg = StoreTransitionDescriptor::MapRegister(); 373 Register map_reg = StoreTransitionDescriptor::MapRegister();
374 DCHECK(!map_reg.is(scratch)); 374 DCHECK(!map_reg.is(scratch));
375 __ LoadWeakValue(map_reg, cell, miss); 375 __ LoadWeakValue(map_reg, cell, miss);
376 if (transition->CanBeDeprecated()) { 376 if (transition->CanBeDeprecated()) {
377 __ Ldrsw(scratch, FieldMemOperand(map_reg, Map::kBitField3Offset)); 377 __ Ldrsw(scratch, FieldMemOperand(map_reg, Map::kBitField3Offset));
378 __ TestAndBranchIfAnySet(scratch, Map::Deprecated::kMask, miss); 378 __ TestAndBranchIfAnySet(scratch, Map::Deprecated::kMask, miss);
379 } 379 }
380 } 380 }
381 381
382 382
383 void NamedStoreHandlerCompiler::GenerateConstantCheck(Object* constant, 383 void NamedStoreHandlerCompiler::GenerateConstantCheck(Register map_reg,
384 int descriptor,
384 Register value_reg, 385 Register value_reg,
386 Register scratch,
385 Label* miss_label) { 387 Label* miss_label) {
386 __ LoadObject(scratch1(), handle(constant, isolate())); 388 DCHECK(!map_reg.is(scratch));
387 __ Cmp(value_reg, scratch1()); 389 DCHECK(!map_reg.is(value_reg));
390 DCHECK(!value_reg.is(scratch));
391 __ LoadInstanceDescriptors(map_reg, scratch);
392 __ Ldr(scratch,
393 FieldMemOperand(scratch, DescriptorArray::GetValueOffset(descriptor)));
394 __ Cmp(value_reg, scratch);
388 __ B(ne, miss_label); 395 __ B(ne, miss_label);
389 } 396 }
390 397
391 398
392 void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(HeapType* field_type, 399 void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(HeapType* field_type,
393 Register value_reg, 400 Register value_reg,
394 Label* miss_label) { 401 Label* miss_label) {
395 __ JumpIfSmi(value_reg, miss_label); 402 __ JumpIfSmi(value_reg, miss_label);
396 HeapType::Iterator<Map> it = field_type->Classes(); 403 HeapType::Iterator<Map> it = field_type->Classes();
397 if (!it.Done()) { 404 if (!it.Done()) {
(...skipping 303 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 // Return the generated code. 708 // Return the generated code.
702 return GetCode(kind(), Code::FAST, name); 709 return GetCode(kind(), Code::FAST, name);
703 } 710 }
704 711
705 712
706 #undef __ 713 #undef __
707 } 714 }
708 } // namespace v8::internal 715 } // namespace v8::internal
709 716
710 #endif // V8_TARGET_ARCH_IA32 717 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698