Introduce toV8NoInline

Source/bindings/scripts/code_generator_v8.pm

Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 2bdd440753d9592507703936591aa7576267375e..651b95645fa189eddd0f7b478acdbc17a89bf3f8 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -4131,6 +4131,7 @@ sub GenerateImplementation
     AddToImplIncludes("core/dom/Document.h");
     AddToImplIncludes("RuntimeEnabledFeatures.h");
     AddToImplIncludes("platform/TraceEvent.h");
+    AddToImplIncludes("bindings/v8/ScriptPromiseResolver.h") if $interface->extendedAttributes->{"PromiseResolutionTarget"};
 
     AddIncludesForType($interfaceName);
     if ($interface->extendedAttributes->{"CheckSecurity"}) {
@@ -4752,6 +4753,23 @@ void ${v8ClassName}::derefObject(void* object)
 }
 
 END
+    # Generate ScriptPromiseResolver::resolve and ScriptPromiseResolver::reject
+    if ($interface->extendedAttributes->{"PromiseResolutionTarget"}) {
+        $implementation{nameSpaceWebCore}->add(<<END);
+template<>
+void ScriptPromiseResolver::resolve(${nativeType}* impl, v8::Handle<v8::Object> creationContext)

[haraken, 2013/11/22 06:01:17]

It looks weird to generate ScriptPromiseResolver methods in generated files.
Would you elaborate on what problem you're going to solve?

(c.f., we generate toEventTarget() to help EventTarget methods to get
EventTarget objects, but we never generate EventTarget methods in generated
files.)

[yhirano, 2013/11/22 06:32:31]

I want to implement

template<typename T>
void ScriptPromiseResolver::resolve(T* impl, v8::Handle<v8::Object>)
(and reject)

.

One possible solution is declaring
template<typename T>
v8::Handle<v8::Value> toV8NonInline(T*, v8::Handle<v8::Object>, v8::Isolate*);
in V8Binding.h and implementing each specialized function in the corresponding
generated source.
Then we can implement generic resolve and reject in ScriptPromiseResolver.h by
using toV8NonInline.

Is it more preferable?

+{
+    resolve(toV8(impl, creationContext, m_isolate));
+}
+
+template<>
+void ScriptPromiseResolver::reject(${nativeType}* impl, v8::Handle<v8::Object> creationContext)
+{
+    reject(toV8(impl, creationContext, m_isolate));
+}
+
+END
+    }
 }
 
 sub GenerateHeaderContentHeader