Introduce toV8NoInline

Source/bindings/scripts/code_generator_v8.pm

 # Copyright (C) 2005, 2006 Nikolas Zimmermann <zimmermann@kde.org>
 # Copyright (C) 2006 Anders Carlsson <andersca@mac.com>
 # Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
 # Copyright (C) 2006 Alexey Proskuryakov <ap@webkit.org>
 # Copyright (C) 2006 Apple Computer, Inc.
 # Copyright (C) 2007, 2008, 2009, 2012 Google Inc.
 # Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
 # Copyright (C) Research In Motion Limited 2010. All rights reserved.
 # Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
 # Copyright (C) 2012 Ericsson AB. All rights reserved.
@@ skipping 4113 matching lines @@
     my $implClassName = GetImplName($interface);
     my $v8ClassName = GetV8ClassName($interface);
     my $nativeType = GetNativeTypeForConversions($interface);
 
     AddToImplIncludes("bindings/v8/V8Binding.h");
     AddToImplIncludes("bindings/v8/V8DOMWrapper.h");
     AddToImplIncludes("core/dom/ContextFeatures.h");
     AddToImplIncludes("core/dom/Document.h");
     AddToImplIncludes("RuntimeEnabledFeatures.h");
     AddToImplIncludes("platform/TraceEvent.h");
+    AddToImplIncludes("bindings/v8/ScriptPromiseResolver.h") if $interface->extendedAttributes->{"PromiseResolutionTarget"};
 
     AddIncludesForType($interfaceName);
     if ($interface->extendedAttributes->{"CheckSecurity"}) {
         AddToImplIncludes("bindings/v8/BindingSecurity.h");
         AddToImplIncludes("bindings/v8/ExceptionMessages.h");
         AddToImplIncludes("bindings/v8/ExceptionState.h");
     }
 
     my $toActiveDOMObject = InheritsExtendedAttribute($interface, "ActiveDOMObject") ? "${v8ClassName}::toActiveDOMObject" : "0";
     my $toEventTarget = InheritsInterface($interface, "EventTarget") ? "${v8ClassName}::toEventTarget" : "0";
@@ skipping 601 matching lines @@
 
     GenerateToV8Converters($interface, $v8ClassName, $nativeType);
 
     $implementation{nameSpaceWebCore}->add(<<END);
 void ${v8ClassName}::derefObject(void* object)
 {
     fromInternalPointer(object)->deref();
 }
 
 END
+    # Generate ScriptPromiseResolver::resolve and ScriptPromiseResolver::reject
+    if ($interface->extendedAttributes->{"PromiseResolutionTarget"}) {
+        $implementation{nameSpaceWebCore}->add(<<END);
+template<>
+void ScriptPromiseResolver::resolve(${nativeType}* impl, v8::Handle<v8::Object> creationContext)

[haraken, 2013/11/22 06:01:17]

It looks weird to generate ScriptPromiseResolver methods in generated files.
Would you elaborate on what problem you're going to solve?

(c.f., we generate toEventTarget() to help EventTarget methods to get
EventTarget objects, but we never generate EventTarget methods in generated
files.)

[yhirano, 2013/11/22 06:32:31]

I want to implement

template<typename T>
void ScriptPromiseResolver::resolve(T* impl, v8::Handle<v8::Object>)
(and reject)

.

One possible solution is declaring
template<typename T>
v8::Handle<v8::Value> toV8NonInline(T*, v8::Handle<v8::Object>, v8::Isolate*);
in V8Binding.h and implementing each specialized function in the corresponding
generated source.
Then we can implement generic resolve and reject in ScriptPromiseResolver.h by
using toV8NonInline.

Is it more preferable?

+{
+    resolve(toV8(impl, creationContext, m_isolate));
+}
+
+template<>
+void ScriptPromiseResolver::reject(${nativeType}* impl, v8::Handle<v8::Object> creationContext)
+{
+    reject(toV8(impl, creationContext, m_isolate));
+}
+
+END
+    }
 }
 
 sub GenerateHeaderContentHeader
 {
     my $interface = shift;
     my $v8ClassName = GetV8ClassName($interface);
     my $conditionalString = GenerateConditionalString($interface);
 
     my @headerContentHeader = split("\r", $licenseHeader);
 
@@ skipping 1579 matching lines @@
     my $interface = shift;
 
     return 1 if $interface->extendedAttributes->{"CustomToV8"};
     return 1 if $interface->extendedAttributes->{"SpecialWrapFor"};
     return 1 if InheritsInterface($interface, "Document");
 
     return 0;
 }
 
 1;