Refactor: Extract some duplicated code for verifying usages during import of asymmetric key.

Refactor: Extract some duplicated code for verifying usages during import of asymmetric key.

Committed: https://crrev.com/df493e2c9a0e4d153dcd9f712ae72b876857b270
Cr-Commit-Position: refs/heads/master@{#307581}

[eroman, 2014-12-09 20:27:08]

eroman@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2014-12-09 20:36:40]

https://codereview.chromium.org/787123003/diff/1/content/child/webcrypto/webc...
File content/child/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/787123003/diff/1/content/child/webcrypto/webc...
content/child/webcrypto/webcrypto_util.cc:281: return status;
I think this got inverted from the original code. It used to be valid if either
was success, but now it requires both be success.

[eroman, 2014-12-09 20:41:54]

https://codereview.chromium.org/787123003/diff/1/content/child/webcrypto/webc...
File content/child/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/787123003/diff/1/content/child/webcrypto/webc...
content/child/webcrypto/webcrypto_util.cc:281: return status;
On 2014/12/09 20:36:39, David Benjamin wrote:
> I think this got inverted from the original code. It used to be valid if
either
> was success, but now it requires both be success.

Ugh you are right! I will restore the original code.
I should have run the tests before sending this, sorry!

[eroman, 2014-12-09 20:46:40]

https://codereview.chromium.org/787123003/diff/1/content/child/webcrypto/webc...
File content/child/webcrypto/webcrypto_util.cc (right):

https://codereview.chromium.org/787123003/diff/1/content/child/webcrypto/webc...
content/child/webcrypto/webcrypto_util.cc:281: return status;
On 2014/12/09 20:41:54, eroman wrote:
> On 2014/12/09 20:36:39, David Benjamin wrote:
> > I think this got inverted from the original code. It used to be valid if
> either
> > was success, but now it requires both be success.
> 
> Ugh you are right! I will restore the original code.
> I should have run the tests before sending this, sorry!

OK Fixed.

I reordered it a bit from the original version to match the early-return style
of other functions.

[davidben, 2014-12-09 21:34:09]

lgtm

[eroman, 2014-12-09 22:17:25]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-12-09 22:18:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/787123003/20001

[commit-bot: I haz the power, 2014-12-09 23:21:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-09 23:22:36]

Patchset 2 (id:??) landed as
https://crrev.com/df493e2c9a0e4d153dcd9f712ae72b876857b270
Cr-Commit-Position: refs/heads/master@{#307581}