Make chrome://salsa more like other WebUI code.

Make chrome://salsa more like other WebUI code.

R=charliemooney@chromium.org
BUG=none
TEST=easier to scan code

Committed: https://crrev.com/2246f3544b016e788e134848b24416c2ae9c052f
Cr-Commit-Position: refs/heads/master@{#308156}

[Dan Beam, 2014-12-10 19:19:48]

will add xiyuan@ after for OWNERS

https://codereview.chromium.org/786933007/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/salsa.html (left):

https://codereview.chromium.org/786933007/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/salsa.html:27: <p
class='bold'>Instructions</p>
no reason for single quotes (') or class="bold"

https://codereview.chromium.org/786933007/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/salsa.html:39: default values at <a
href="chrome://gesture">http://gesture</a>.
this is supposed to be chrome://gesture, right? (instead of http://)

https://codereview.chromium.org/786933007/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/salsa.html (right):

https://codereview.chromium.org/786933007/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/salsa.html:14: <div
id="invalid-treatment-info" hidden>
- over _ in IDs

https://codereview.chromium.org/786933007/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/salsa.js (left):

https://codereview.chromium.org/786933007/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/salsa.js:94: function
applyTreatment(treatment_number) {
jsVarsLikeThis

https://codereview.chromium.org/786933007/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/salsa.js (right):

https://codereview.chromium.org/786933007/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/salsa.js:136:
$('invalid-treatment-info').hidden = false;
we do this a lot more

[Dan Beam, 2014-12-12 00:08:32]

ping

[charliemooney1, 2014-12-12 16:18:18]

On 2014/12/12 00:08:32, Dan Beam wrote:
> ping

lgtm, thanks!

[Dan Beam, 2014-12-12 18:17:56]

dbeam@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Dan Beam, 2014-12-12 18:18:19]

+xiyuan@ for owners

[xiyuan, 2014-12-12 19:41:54]

lgtm

[Dan Beam, 2014-12-12 19:42:16]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-12-12 19:44:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786933007/1

[commit-bot: I haz the power, 2014-12-12 20:48:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-12 20:53:11]

Patchset 1 (id:??) landed as
https://crrev.com/2246f3544b016e788e134848b24416c2ae9c052f
Cr-Commit-Position: refs/heads/master@{#308156}