Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/resources/chromeos/salsa.html

Issue 786933007: Make chrome://salsa more like other WebUI code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/salsa.html
diff --git a/chrome/browser/resources/chromeos/salsa.html b/chrome/browser/resources/chromeos/salsa.html
index 22cbfb10e81794751aa3b69a19bcf895c7c9b3d1..2d31eae894ad19773553f3c3c0c3535a6affe0ef 100644
--- a/chrome/browser/resources/chromeos/salsa.html
+++ b/chrome/browser/resources/chromeos/salsa.html
@@ -11,24 +11,24 @@
<div id="bounding-box">
<h1 class="title">Salsa</h1>
- <div id="invalid_treatment_info" hidden>
+ <div id="invalid-treatment-info" hidden>
Dan Beam 2014/12/10 19:19:47 - over _ in IDs
I'm afraid there has been some problem determining which treatments to use
for your experiment. Please try to copy/paste the URL again and refresh
this page. If the problem persists please contact the person running the
experiment.
</div>
- <div id="valid_treatment_info">
+ <div id="valid-treatment-info">
<div id="treatment-list">
<div id="treatment-header">Available Treatments:</div>
<div id="treatment-template" class="treatment" hidden></div>
</div>
- <p class='bold'>Instructions</p>
Dan Beam 2014/12/10 19:19:47 no reason for single quotes (') or class="bold"
+ <p>Instructions</p>
<ul id="instructions">
- <li> <span class='bold'>Click</span> or use your <span class='bold'>arrow
- keys</span> to change the selected treatment.
+ <li> <span>Click</span> or use your <span>arrow keys</span> to change the
+ selected treatment.
<li> Treatments are ordered randomly, so there is no special significance
to their labels.
@@ -36,10 +36,10 @@
<li> When you navigate away from this page your settings will be returned
to normal. If the browser crashes, and/or you experience unusual behavior
after this experiment, you can manually reset your settings to their
- default values at <a href="chrome://gesture">http://gesture</a>.
Dan Beam 2014/12/10 19:19:47 this is supposed to be chrome://gesture, right? (i
+ default values at <a href="chrome://gesture">chrome://gesture</a>.
</ul>
- <p class='bold'>Thank you for your participation!</p>
+ <p>Thank you for your participation!</p>
</div>
</div>

Powered by Google App Engine
This is Rietveld 408576698