Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 786903002: devtools_protocol.cc: fix ptr to bool conversion warning (Closed)

Created:
6 years ago by hans
Modified:
6 years ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, yurys, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
precise:/work/chromium/src@clang_roll_223109
Project:
chromium
Visibility:
Public.

Description

devtools_protocol.cc: fix ptr to bool conversion warning ../../chrome/browser/devtools/devtools_protocol.cc:120:12: error: implicit conversion of nullptr constant to 'bool' [-Werror,-Wnull-conversion] return nullptr; ~~~~~~ ^~~~~~~ false BUG=431803 TBR=pfeldman NOTRY=true Committed: https://crrev.com/448c20706e3786c10db5abeadd2ada9c20a8ac81 Cr-Commit-Position: refs/heads/master@{#307389}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/devtools/devtools_protocol.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786903002/1
6 years ago (2014-12-09 00:55:55 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 00:56:28 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-09 00:57:18 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/448c20706e3786c10db5abeadd2ada9c20a8ac81
Cr-Commit-Position: refs/heads/master@{#307389}

Powered by Google App Engine
This is Rietveld 408576698