Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: chrome/browser/devtools/devtools_protocol.cc

Issue 786903002: devtools_protocol.cc: fix ptr to bool conversion warning (Closed) Base URL: precise:/work/chromium/src@clang_roll_223109
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_protocol.cc
diff --git a/chrome/browser/devtools/devtools_protocol.cc b/chrome/browser/devtools/devtools_protocol.cc
index cc31ef9e0abaa7aa6399f859b0f6fb617817e573..8df05578c5f639c8396645a63bb3dcbe549a86a0 100644
--- a/chrome/browser/devtools/devtools_protocol.cc
+++ b/chrome/browser/devtools/devtools_protocol.cc
@@ -117,13 +117,13 @@ bool DevToolsProtocol::ParseResponse(const std::string& json,
int* error_code) {
scoped_ptr<base::Value> value(base::JSONReader::Read(json));
if (!value || !value->IsType(base::Value::TYPE_DICTIONARY))
- return nullptr;
+ return false;
scoped_ptr<base::DictionaryValue> dict(
static_cast<base::DictionaryValue*>(value.release()));
if (!dict->GetInteger(kIdParam, command_id))
- return nullptr;
+ return false;
*error_code = 0;
base::DictionaryValue* error_dict = nullptr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698