chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc - Issue 786823002: PasswordFormManager takes WeakPtr<PasswordManagerDriver>

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 786823002: PasswordFormManager takes WeakPtr<PasswordManagerDriver> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SupportsWeakPtr Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_test.cc ('k') | components/password_manager/content/browser/credential_manager_password_form_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

index ec81b5f704ee6e9d5119cd799d655fea1bf0ba48..1a5e874cab575cc84431781b54b14fe768d4740b 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

@@ -120,7 +120,7 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordSubmitted) {

password_manager::StubPasswordManagerDriver driver;

scoped_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

- NULL, &client, &driver, test_form(), false));

+ NULL, &client, driver.AsWeakPtr(), test_form(), false));

controller()->OnPasswordSubmitted(test_form_manager.Pass());

EXPECT_EQ(password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE,

controller()->state());

@@ -142,7 +142,7 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordSaved) {

password_manager::StubPasswordManagerDriver driver;

scoped_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

- NULL, &client, &driver, test_form(), false));

+ NULL, &client, driver.AsWeakPtr(), test_form(), false));

controller()->OnPasswordSubmitted(test_form_manager.Pass());

ManagePasswordsIconMock mock;

@@ -157,7 +157,7 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordBlacklisted) {

password_manager::StubPasswordManagerDriver driver;

scoped_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

- NULL, &client, &driver, test_form(), false));

+ NULL, &client, driver.AsWeakPtr(), test_form(), false));

controller()->OnPasswordSubmitted(test_form_manager.Pass());

ManagePasswordsIconMock mock;

@@ -172,7 +172,7 @@ TEST_F(ManagePasswordsUIControllerTest, QuickNavigations) {

password_manager::StubPasswordManagerDriver driver;

scoped_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

- NULL, &client, &driver, test_form(), false));

+ NULL, &client, driver.AsWeakPtr(), test_form(), false));

controller()->OnPasswordSubmitted(test_form_manager.Pass());

ManagePasswordsIconMock mock;

controller()->UpdateIconAndBubbleState(&mock);

@@ -199,7 +199,7 @@ TEST_F(ManagePasswordsUIControllerTest, SlowNavigations) {

password_manager::StubPasswordManagerDriver driver;

scoped_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

- NULL, &client, &driver, test_form(), false));

+ NULL, &client, driver.AsWeakPtr(), test_form(), false));

controller()->OnPasswordSubmitted(test_form_manager.Pass());

ManagePasswordsIconMock mock;

controller()->UpdateIconAndBubbleState(&mock);

@@ -227,7 +227,7 @@ TEST_F(ManagePasswordsUIControllerTest, PasswordSubmittedToNonWebbyURL) {

password_manager::StubPasswordManagerDriver driver;

scoped_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

- NULL, &client, &driver, test_form(), false));

+ NULL, &client, driver.AsWeakPtr(), test_form(), false));

controller()->OnPasswordSubmitted(test_form_manager.Pass());

EXPECT_EQ(password_manager::ui::INACTIVE_STATE, controller()->state());

EXPECT_FALSE(controller()->PasswordPendingUserDecision());

@@ -327,7 +327,7 @@ TEST_F(ManagePasswordsUIControllerTest, AutomaticPasswordSave) {

password_manager::StubPasswordManagerDriver driver;

scoped_ptr<password_manager::PasswordFormManager> test_form_manager(

new password_manager::PasswordFormManager(

- NULL, &client, &driver, test_form(), false));

+ NULL, &client, driver.AsWeakPtr(), test_form(), false));

controller()->OnAutomaticPasswordSave(test_form_manager.Pass());

EXPECT_EQ(password_manager::ui::CONFIRMATION_STATE, controller()->state());