Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9015)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/passwords/manage_passwords_test.cc

Issue 786823002: PasswordFormManager takes WeakPtr<PasswordManagerDriver> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SupportsWeakPtr Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_test.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_test.cc b/chrome/browser/ui/passwords/manage_passwords_test.cc
index adb9efcc695bd4bfa56ec29fd3a2108e2e7ac347..db100dbd1abd4d03bc0bcbb21627401880a48838 100644
--- a/chrome/browser/ui/passwords/manage_passwords_test.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_test.cc
@@ -49,7 +49,7 @@ void ManagePasswordsTest::SetupPendingPassword() {
password_manager::StubPasswordManagerDriver driver;
scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
new password_manager::PasswordFormManager(
- NULL, &client, &driver, *test_form(), false));
+ NULL, &client, driver.AsWeakPtr(), *test_form(), false));
GetController()->OnPasswordSubmitted(test_form_manager.Pass());
// Wait for the command execution triggered by the automatic popup to pop up
@@ -63,7 +63,7 @@ void ManagePasswordsTest::SetupAutomaticPassword() {
password_manager::StubPasswordManagerDriver driver;
scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
new password_manager::PasswordFormManager(
- NULL, &client, &driver, *test_form(), false));
+ NULL, &client, driver.AsWeakPtr(), *test_form(), false));
GetController()->OnAutomaticPasswordSave(test_form_manager.Pass());
// Wait for the command execution triggered by the automatic popup to pop up
« no previous file with comments | « no previous file | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698