Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 786813004: Generate correct KeyboardCode (VKEY). (Closed)

Created:
6 years ago by kpschoedel
Modified:
6 years ago
Reviewers:
*spang
CC:
chromium-reviews, kalyank, jdduke+watch_chromium.org, ozone-reviews_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@x430194-xkb
Project:
chromium
Visibility:
Public.

Description

Generate correct KeyboardCode (VKEY). BUG=430194 Committed: https://crrev.com/0978031a3fff5eb1096417614005d2e34889ffc4 Cr-Commit-Position: refs/heads/master@{#308469}

Patch Set 1 #

Total comments: 12

Patch Set 2 : address review comments (spang) #

Patch Set 3 : rebase 2014/12/08 #

Patch Set 4 : rebase after crrev.com/308447 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1551 lines, -51 lines) Patch
M ui/events/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/events.gyp View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/ozone/layout/layout_util.h View 1 chunk +10 lines, -3 lines 0 comments Download
M ui/events/ozone/layout/layout_util.cc View 4 chunks +63 lines, -16 lines 0 comments Download
M ui/events/ozone/layout/stub/stub_keyboard_layout_engine.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/layout/xkb/xkb_key_code_converter.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.h View 1 2 3 2 chunks +35 lines, -15 lines 0 comments Download
M ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine.cc View 1 2 3 5 chunks +682 lines, -12 lines 0 comments Download
A ui/events/ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc View 1 2 3 1 chunk +746 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kpschoedel
Depends on https://codereview.chromium.org/778503002/ which depends on https://codereview.chromium.org/742103002/
6 years ago (2014-12-08 21:28:09 UTC) #3
spang
https://codereview.chromium.org/786813004/diff/1/ui/events/BUILD.gn File ui/events/BUILD.gn (right): https://codereview.chromium.org/786813004/diff/1/ui/events/BUILD.gn#newcode334 ui/events/BUILD.gn:334: "ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc", needs use_xkbcommon condition https://codereview.chromium.org/786813004/diff/1/ui/events/events.gyp File ui/events/events.gyp (right): https://codereview.chromium.org/786813004/diff/1/ui/events/events.gyp#newcode357 ...
6 years ago (2014-12-08 23:07:30 UTC) #4
kpschoedel
https://codereview.chromium.org/786813004/diff/1/ui/events/BUILD.gn File ui/events/BUILD.gn (right): https://codereview.chromium.org/786813004/diff/1/ui/events/BUILD.gn#newcode334 ui/events/BUILD.gn:334: "ozone/layout/xkb/xkb_keyboard_layout_engine_unittest.cc", On 2014/12/08 23:07:30, spang wrote: > needs use_xkbcommon ...
6 years ago (2014-12-09 00:32:37 UTC) #5
spang
lgtm
6 years ago (2014-12-09 00:43:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786813004/60001
6 years ago (2014-12-15 23:15:53 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-16 00:13:16 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-16 00:14:00 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/0978031a3fff5eb1096417614005d2e34889ffc4
Cr-Commit-Position: refs/heads/master@{#308469}

Powered by Google App Engine
This is Rietveld 408576698