ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc - Issue 786813004: Generate correct KeyboardCode (VKEY).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc

Issue 786813004: Generate correct KeyboardCode (VKEY). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x430194-xkb

Patch Set: rebase after crrev.com/308447 Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc

diff --git a/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc b/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc

index 0f6a6e86e9e0bcd4ed60b6e05998fddb49ee5caf..b1eb22a836d80eb2c8cea44954a94cfc19c865ea 100644

--- a/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc

+++ b/ui/events/ozone/layout/xkb/xkb_keyboard_code_conversion.cc

@@ -8,7 +8,7 @@

namespace ui {

-DomKey XkbKeySymToDomKey(xkb_keysym_t keysym) {

+DomKey NonPrintableXkbKeySymToDomKey(xkb_keysym_t keysym) {

switch (keysym) {

case XKB_KEY_BackSpace:

return DomKey::BACKSPACE;

@@ -377,7 +377,7 @@ DomKey XkbKeySymToDomKey(xkb_keysym_t keysym) {

}

-base::char16 XkbKeySymDeadKey(xkb_keysym_t keysym) {

+base::char16 DeadXkbKeySymToCombiningCharacter(xkb_keysym_t keysym) {

switch (keysym) {

case XKB_KEY_dead_grave:

return 0x0768; // combining grave accent