Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: dart/pkg/logging/test/logging_test.dart

Issue 786813002: Adding a "zone" value to "class LogRecord" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dart/pkg/logging/lib/logging.dart ('K') | « dart/pkg/logging/lib/logging.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/pkg/logging/test/logging_test.dart
diff --git a/dart/pkg/logging/test/logging_test.dart b/dart/pkg/logging/test/logging_test.dart
index 223498f0a1707b4ae93accfdc9fa4803717be98b..d01144face233718cda7056a37c67990fcae2235 100644
--- a/dart/pkg/logging/test/logging_test.dart
+++ b/dart/pkg/logging/test/logging_test.dart
@@ -5,6 +5,8 @@
library logging_test;
+import 'dart:async';
+
import 'package:logging/logging.dart';
import 'package:unittest/unittest.dart';
@@ -150,6 +152,36 @@ main() {
expect(shout.stackTrace, isNull);
});
+ group('current Zone gets recorded to LogRecord', () {
+ test('root zone', () {
+ var root = Logger.root;
+
+ var recordingZone = Zone.current;
+ var records = new List<LogRecord>();
+ root.onRecord.listen(records.add);
+ root.info('hello');
+
+ expect(records, hasLength(1));
+ expect(records.first.zone, equals(recordingZone));
+ });
+
+ test('child zone', () {
+ var root = Logger.root;
+
+ var recordingZone;
+ var records = new List<LogRecord>();
+ root.onRecord.listen(records.add);
+
+ runZoned(() {
+ recordingZone = Zone.current;
+ root.info('hello');
+ });
+
+ expect(records, hasLength(1));
+ expect(records.first.zone, equals(recordingZone));
Søren Gjesse 2014/12/09 07:48:35 I assume this one would fail before.
kustermann 2015/01/07 12:38:44 Can you explain what you mean here? Before my CL t
Søren Gjesse 2015/01/07 12:50:01 My comment didn't really make sense.
+ });
+ });
+
group('mutating levels', () {
Logger root = Logger.root;
Logger a = new Logger('a');
« dart/pkg/logging/lib/logging.dart ('K') | « dart/pkg/logging/lib/logging.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698