Adding a "zone" value to "class LogRecord"

dart/pkg/logging/test/logging_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 library logging_test;
 
+import 'dart:async';
+
 import 'package:logging/logging.dart';
 import 'package:unittest/unittest.dart';
 
 main() {
   test('level comparison is a valid comparator', () {
     var level1 = const Level('NOT_REAL1', 253);
     expect(level1 == level1, isTrue);
     expect(level1 <= level1, isTrue);
     expect(level1 >= level1, isTrue);
     expect(level1 < level1, isFalse);
@@ skipping 125 matching lines @@
     expect(warning.message, 'warning');
     expect(warning.error is UnsupportedError, isTrue);
     expect(warning.stackTrace is StackTrace, isTrue);
 
     var shout = records[2];
     expect(shout.message, 'shout');
     expect(shout.error, isNull);
     expect(shout.stackTrace, isNull);
   });
 
+  group('current Zone gets recorded to LogRecord', () {
+    test('root zone', () {
+      var root = Logger.root;
+
+      var recordingZone = Zone.current;
+      var records = new List<LogRecord>();
+      root.onRecord.listen(records.add);
+      root.info('hello');
+
+      expect(records, hasLength(1));
+      expect(records.first.zone, equals(recordingZone));
+    });
+
+    test('child zone', () {
+      var root = Logger.root;
+
+      var recordingZone;
+      var records = new List<LogRecord>();
+      root.onRecord.listen(records.add);
+
+      runZoned(() {
+        recordingZone = Zone.current;
+        root.info('hello');
+      });
+
+      expect(records, hasLength(1));
+      expect(records.first.zone, equals(recordingZone));

[Søren Gjesse, 2014/12/09 07:48:35]

I assume this one would fail before.

[kustermann, 2015/01/07 12:38:44]

Can you explain what you mean here? Before my CL there was no 'zone' field.

What this ensures is that the zone at log.info() will record the zone the call
was made in -- even if in a child zone of root.

[Søren Gjesse, 2015/01/07 12:50:01]

My comment didn't really make sense.

+    });
+  });
+
   group('mutating levels', () {
     Logger root = Logger.root;
     Logger a = new Logger('a');
     Logger b = new Logger('a.b');
     Logger c = new Logger('a.b.c');
     Logger d = new Logger('a.b.c.d');
     Logger e = new Logger('a.b.c.d.e');
 
     setUp(() {
       hierarchicalLoggingEnabled = true;
@@ skipping 288 matching lines @@
       root.info(() => 10);
 
       expect(messages, equals([
           'INFO: 5',
           'INFO: false',
           'INFO: [1, 2, 3]',
           'INFO: 10',]));
     });
   });
 }