Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 7866017: If a GraphicsLayerChromium goes away during the middle of paint, its (Closed)

Created:
8 years, 11 months ago by enne (OOO)
Modified:
8 years, 10 months ago
Reviewers:
jamesr, nduca, enne_
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/
Visibility:
Public.

Description

If a GraphicsLayerChromium goes away during the middle of paint, its CCLayerImpl will be kept alive in the render surface layer list, but its render surface will be cleared. updateCompositorResources and drawLayers is not robust to this. Rather than trying to modify the destruction order, just add safety checks.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp View 4 chunks +9 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
nduca
http://codereview.chromium.org/7866017/diff/1/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp File Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp (right): http://codereview.chromium.org/7866017/diff/1/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp#newcode979 Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:979: if (!ccLayerImpl) (drive by) How do we prevent this ...
8 years, 11 months ago (2011-09-09 23:24:09 UTC) #1
jamesr
On 2011/09/09 23:24:09, nduca wrote: > http://codereview.chromium.org/7866017/diff/1/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp > File Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp > (right): > > http://codereview.chromium.org/7866017/diff/1/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp#newcode979 ...
8 years, 11 months ago (2011-09-09 23:28:51 UTC) #2
enne_
On 2011/09/09 23:24:09, nduca wrote: > (drive by) How do we prevent this crap from ...
8 years, 11 months ago (2011-09-09 23:34:32 UTC) #3
nduca
8 years, 11 months ago (2011-09-09 23:37:23 UTC) #4
Hehe sounds good (and LGTM). Apologies in advance for having an opinion on
something I know a bit too little about...

This smells like more of the "RenderSurfaces" conflate the "curent frame's
drawing list" with "we want to have a pool of rendertargets so we don't allocate
them each frame."

Naievely, If we built the drawing list every frame, then just looked aside to a
cache for available rendertargets, wouldn't we be simplify things a bit?

Powered by Google App Engine
This is Rietveld 408576698