Cleaning up MruWindowTracker::BuildWindowList()

Cleaning up MruWindowTracker::BuildWindowList()

Removing the top_most_at_end parameter which was always set to false and
was never used.

R=oshima@chromium.org
BUG=None

Committed: https://crrev.com/f3848eee6c17acc74543c803bcea7ea542e13cbc
Cr-Commit-Position: refs/heads/master@{#307135}

[oshima, 2014-12-06 00:26:03]

lgtm. 

can you update the description

BUG=None

you don't need TEST section

https://codereview.chromium.org/786513003/diff/1/ash/wm/window_positioner.cc
File ash/wm/window_positioner.cc (right):

https://codereview.chromium.org/786513003/diff/1/ash/wm/window_positioner.cc#...
ash/wm/window_positioner.cc:506: const std::vector<aura::Window*> windows =
does this fit single line?

[afakhry, 2014-12-06 00:30:40]

https://codereview.chromium.org/786513003/diff/1/ash/wm/window_positioner.cc
File ash/wm/window_positioner.cc (right):

https://codereview.chromium.org/786513003/diff/1/ash/wm/window_positioner.cc#...
ash/wm/window_positioner.cc:506: const std::vector<aura::Window*> windows =
On 2014/12/06 00:26:03, oshima wrote:
> does this fit single line?

It doesn't ... the semicolon will exceed the boundary.

[afakhry, 2014-12-06 00:31:17]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2014-12-06 00:32:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/786513003/1

[commit-bot: I haz the power, 2014-12-06 01:24:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-12-06 01:24:58]

Patchset 1 (id:??) landed as
https://crrev.com/f3848eee6c17acc74543c803bcea7ea542e13cbc
Cr-Commit-Position: refs/heads/master@{#307135}

[gab, 2014-12-08 15:03:01]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/790503003/ by gab@chromium.org.

The reason for reverting is: I don't see why this would cause any problems, it
looks like a purely aesthetic, yet this is the only Ash related CL in the
regression range [1] for ever-failing Win8 Aura [2] and Win7(dbg) ash_unittests
since these commits.

(the test failures seem to be timing out with no output, weird... I'll check
this back in if the revert doesn't help...)

[1]
https://chromium.googlesource.com/chromium/src/+log/8e72e1d6c13fa6a4cf2859ac6...

[2]http://build.chromium.org/p/chromium.win/builders/Win8%20Aura

Failing tests:

ToggleMinimized
WindowDockLeftMinimizeWindowWithRestore
WindowPanelDockLeftDockRightRestore
WindowSnapLeftDockLeftRestore
WindowSnapLeftDockLeftSnapRight
WindowSnapRightDockRightRestore
EventsDoNotLeakToWindowUnderneath
Basic
MinimizedWindowsAreLru
GestureSwipe
SwipeUpDownWithoutReleasing
VerticalSwipes
PanelsHideAndRestoreWithShelf
AcceleratorsWithFullscreen
WorkAreaChangeWorkspace
AlwaysOnTopMultiWindow
AlwaysOnTopWindow
CycleMruPanelDestroyed
CyclePanels
CyclePanelsDestroyed
HandleCycleWindow
MaximizedWindow
MostRecentlyUsed
SelectingHidesAppList
SecondMaximizedWindowHasProperRestoreSize
ActivationCancelsOveriew
Basic
BasicGesture
BasicTabKeyNavigation
BasicTextFiltering
CloseButton
CloseButtonOnPanels
CreateLabelUnderPanel
FullscreenWindow
FullscreenWindowMaximizeMode
LastWindowDestroyed
NewWindowCancelsOveriew
NoCrashWithDesktopTap
NonActivatableWindowsHidden
SelectWindowWithReturnKey
SelectingHidesAppList
Shutdown
TextFilteringSelection
WindowOverviewHidesCalloutWidgets
AnimatedNormToMaxToNormRepositionsRemaining
AutoPlacingMovesTransientChild
BasicAutoPlacingOnShowHide
NormToMaxToMinRepositionsRemaining
NormToMaxToNormRepositionsRemaining
ShelfStateUpdated
TestSingleWindowsRestoredBounds
TestUserHandledWindowRestore
TestUserMovedWindowRepositioning
ToMinimizeRepositionsRemaining.

[oshima, 2014-12-08 19:05:27]

https://codereview.chromium.org/786513003/diff/1/ash/wm/mru_window_tracker.cc
File ash/wm/mru_window_tracker.cc (left):

https://codereview.chromium.org/786513003/diff/1/ash/wm/mru_window_tracker.cc...
ash/wm/mru_window_tracker.cc:119: std::reverse(windows.begin(), windows.end());
you have to do this always instead. sorry for not catching this, but I wonder
why CQ didn't fail. Can you investigate why?