Cleaning up MruWindowTracker::BuildWindowList()

ash/wm/window_positioner.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/window_positioner.h"
 
 #include "ash/screen_util.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "ash/wm/mru_window_tracker.h"
@@ skipping 174 matching lines @@
                                  bool *single_window) {
   if (single_window)
     *single_window = true;
   // Get the active window.
   aura::Window* active = ash::wm::GetActiveWindow();
   if (active && active->GetRootWindow() != root_window)
     active = NULL;
 
   // Get a list of all windows.
   const std::vector<aura::Window*> windows =
-      ash::MruWindowTracker::BuildWindowList(false);
+      ash::MruWindowTracker::BuildWindowList();
 
   if (windows.empty())
     return NULL;
 
   aura::Window::Windows::const_iterator iter = windows.begin();
   // Find the index of the current active window.
   if (active)
     iter = std::find(windows.begin(), windows.end(), active);
 
   int index = (iter == windows.end()) ? 0 : (iter - windows.begin());
@@ skipping 290 matching lines @@
     last_popup_position_x_ += pop_position_offset_increment_x;
     last_popup_position_y_ += pop_position_offset_increment_y;
   }
   return gfx::Rect(x + work_area.x(), y + work_area.y(), w, h);
 }
 
 gfx::Rect WindowPositioner::SmartPopupPosition(
     const gfx::Rect& old_pos,
     const gfx::Rect& work_area,
     int grid) {
   const std::vector<aura::Window*> windows =

[oshima, 2014/12/06 00:26:03]

does this fit single line?

[afakhry, 2014/12/06 00:30:40]

It doesn't ... the semicolon will exceed the boundary.

-      MruWindowTracker::BuildWindowList(false);
+      MruWindowTracker::BuildWindowList();
 
   std::vector<const gfx::Rect*> regions;
   // Process the window list and check if we can bail immediately.
   for (size_t i = 0; i < windows.size(); i++) {
     // We only include opaque and visible windows.
     if (windows[i] && windows[i]->IsVisible() && windows[i]->layer() &&
         (!windows[i]->transparent() ||
          windows[i]->layer()->GetTargetOpacity() == 1.0)) {
       wm::WindowState* window_state = wm::GetWindowState(windows[i]);
       // When any window is maximized we cannot find any free space.
@@ skipping 64 matching lines @@
   // If the alignment was pushing the window out of the screen, we ignore the
   // alignment for that call.
   if (abs(pos.right() - work_area.right()) < grid)
     x = work_area.right() - w;
   if (abs(pos.bottom() - work_area.bottom()) < grid)
     y = work_area.bottom() - h;
   return gfx::Rect(x, y, w, h);
 }
 
 }  // namespace ash