Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 7864025: Fix two bugs in the code compaction: (Closed)

Created:
9 years, 3 months ago by Vyacheslav Egorov (Chromium)
Modified:
9 years, 3 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix two bugs in the code compaction: 1) Ensure that pc_to_code cache can iterate heap in the middle of compaction. 2) Increase precision of code target patching write-barrier. We shoould never record reloc slots on white objects because they might die and evacuation will overwrite their contents invalidating collected reloc slots as their positions are not aligned in the code stream. 3) remove bogus assertion. R=erik.corry@gmail.com BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -18 lines) Patch
M src/frames.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/incremental-marking.cc View 1 chunk +4 lines, -14 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-09-10 13:24:10 UTC) #1
Erik Corry
9 years, 3 months ago (2011-09-10 13:40:35 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698