Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 786363002: Refactor: Extract common code for generating asymmetric keys to a helper. (Closed)

Created:
6 years ago by eroman
Modified:
6 years ago
Reviewers:
davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Refactor: Extract common code for generating asymmetric keys to a helper. Committed: https://crrev.com/ae20f984468be55a6084ec835e35f94c23b21c70 Cr-Commit-Position: refs/heads/master@{#307860}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : use the old way #

Patch Set 5 : rebase onto master #

Patch Set 6 : rebase #

Patch Set 7 : rebase onto master #

Patch Set 8 : rebase again sigh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -30 lines) Patch
M content/child/webcrypto/nss/rsa_key_nss.cc View 1 2 3 4 5 1 chunk +6 lines, -10 lines 0 comments Download
M content/child/webcrypto/openssl/ec_key_openssl.cc View 1 2 3 4 5 1 chunk +6 lines, -10 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_key_openssl.cc View 1 2 3 4 1 chunk +6 lines, -10 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.h View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
M content/child/webcrypto/webcrypto_util.cc View 1 2 3 4 5 6 7 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
eroman
6 years ago (2014-12-09 18:19:39 UTC) #2
davidben
lgtm
6 years ago (2014-12-10 17:54:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786363002/120001
6 years ago (2014-12-10 22:52:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/16971)
6 years ago (2014-12-11 00:51:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786363002/120001
6 years ago (2014-12-11 02:03:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/17021)
6 years ago (2014-12-11 02:10:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786363002/140001
6 years ago (2014-12-11 03:15:20 UTC) #13
commit-bot: I haz the power
Committed patchset #8 (id:140001)
6 years ago (2014-12-11 04:55:58 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-11 04:56:53 UTC) #15
Message was sent while issue was closed. 
Patchset 8 (id:??) landed as
https://crrev.com/ae20f984468be55a6084ec835e35f94c23b21c70
Cr-Commit-Position: refs/heads/master@{#307860}

Powered by Google App Engine
This is Rietveld 408576698