Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(31)

Issue 7863014: Merge 94841 - Crashes in WebCore::AppendNodeCommand::create(). (Closed)

Created:
9 years, 1 month ago by sullivan
Modified:
9 years, 1 month ago
Reviewers:
sullivan
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/874/
Visibility:
Public.

Description

Merge 94841 - Crashes in WebCore::AppendNodeCommand::create(). https://bugs.webkit.org/show_bug.cgi?id=67767 Patch by Shinya Kawanaka <shinyak@google.com>; on 2011-09-09 Reviewed by Darin Adler. Source/WebCore: In CompositeEditCommand::closeParagraphUnderNewElement(), lastNode could be a non Element node. The current code assumes lastNode is an Element node. This patch checks it. Test: editing/execCommand/ident-crashes-topnode-is-text.html * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added an element node check. LayoutTests: Added a crash test case. * editing/execCommand/ident-crashes-topnode-is-text-expected.txt: Added. * editing/execCommand/ident-crashes-topnode-is-text.html: Added. TBR=sullivan@chromium.org BUG=95550 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94885

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + LayoutTests/editing/execCommand/ident-crashes-topnode-is-text.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/execCommand/ident-crashes-topnode-is-text-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
sullivan
9 years, 1 month ago (2011-09-09 23:09:02 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698