Source/WebCore/editing/CompositeEditCommand.cpp - Issue 7863014: Merge 94841 - Crashes in WebCore::AppendNodeCommand::create().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/editing/CompositeEditCommand.cpp

Issue 7863014: Merge 94841 - Crashes in WebCore::AppendNodeCommand::create(). (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/editing/CompositeEditCommand.cpp

===================================================================

--- Source/WebCore/editing/CompositeEditCommand.cpp (revision 94882)

+++ Source/WebCore/editing/CompositeEditCommand.cpp (working copy)

@@ -808,7 +808,7 @@

appendNode(topNode, blockElement);

RefPtr<Node> lastNode = topNode;

- if (start.deprecatedNode() != outerNode) {

+ if (start.deprecatedNode() != outerNode && lastNode->isElementNode()) {

Vector<RefPtr<Node> > ancestors;

// Insert each node from innerNode to outerNode (excluded) in a list.

« no previous file with comments | « LayoutTests/editing/execCommand/ident-crashes-topnode-is-text-expected.txt ('k') | no next file » | no next file with comments »