Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 786113002: Only terminate latency components when no rendering is scheduled (Closed)

Created:
6 years ago by jdduke (slow)
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Only terminate latency components when no rendering is scheduled The refactoring in r307111 reversed the condition for when a given LatencyInfo would be terminated. Restore the proper condition, which terminates the LatencyInfo when the input event has been ack'ed and has not caused any scheduled rendering. Also add a couple basic smoke tests for RenderWidgetHostLatencyTracker. Committed: https://crrev.com/30db02f950a81d68285196d98e91c56f9b761de3 Cr-Commit-Position: refs/heads/master@{#307397}

Patch Set 1 #

Patch Set 2 : Histogram fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -8 lines) Patch
M content/browser/renderer_host/render_widget_host_latency_tracker.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_latency_tracker.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
A content/browser/renderer_host/render_widget_host_latency_tracker_unittest.cc View 1 chunk +97 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jdduke (slow)
miletus@: PTAL, thanks. sievers@ for owner approval.
6 years ago (2014-12-08 21:29:47 UTC) #2
Yufeng Shen (Slow to review)
lgtm
6 years ago (2014-12-08 22:45:48 UTC) #3
no sievers
lgtm
6 years ago (2014-12-09 00:40:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/786113002/20001
6 years ago (2014-12-09 00:53:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-09 01:44:31 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-09 01:44:59 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30db02f950a81d68285196d98e91c56f9b761de3
Cr-Commit-Position: refs/heads/master@{#307397}

Powered by Google App Engine
This is Rietveld 408576698