Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: content/browser/renderer_host/render_widget_host_latency_tracker.cc

Issue 786113002: Only terminate latency components when no rendering is scheduled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Histogram fix Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_latency_tracker.cc
diff --git a/content/browser/renderer_host/render_widget_host_latency_tracker.cc b/content/browser/renderer_host/render_widget_host_latency_tracker.cc
index fc62885b39dbf9dfd55ba5eb30d36d3145538ea1..2280e34a321d859e1218dd6e91fc3f0da8c6985e 100644
--- a/content/browser/renderer_host/render_widget_host_latency_tracker.cc
+++ b/content/browser/renderer_host/render_widget_host_latency_tracker.cc
@@ -220,7 +220,7 @@ void RenderWidgetHostLatencyTracker::OnInputEventAck(
ui::INPUT_EVENT_LATENCY_RENDERING_SCHEDULED_COMPONENT, 0, NULL);
if (WebInputEvent::isGestureEventType(event.type)) {
- if (rendering_scheduled) {
+ if (!rendering_scheduled) {
latency->AddLatencyNumber(
ui::INPUT_EVENT_LATENCY_TERMINATED_GESTURE_COMPONENT, 0, 0);
// TODO(jdduke): Consider exposing histograms for gesture event types.
@@ -230,23 +230,23 @@ void RenderWidgetHostLatencyTracker::OnInputEventAck(
if (WebInputEvent::isTouchEventType(event.type)) {
latency->AddLatencyNumber(ui::INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT, 0, 0);
- if (rendering_scheduled) {
+ if (!rendering_scheduled) {
latency->AddLatencyNumber(
ui::INPUT_EVENT_LATENCY_TERMINATED_TOUCH_COMPONENT, 0, 0);
- ComputeInputLatencyHistograms(WebInputEvent::TouchTypeFirst,
- latency_component_id_, *latency);
}
+ ComputeInputLatencyHistograms(WebInputEvent::TouchTypeFirst,
+ latency_component_id_, *latency);
return;
}
if (event.type == WebInputEvent::MouseWheel) {
latency->AddLatencyNumber(ui::INPUT_EVENT_LATENCY_ACK_RWH_COMPONENT, 0, 0);
- if (rendering_scheduled) {
+ if (!rendering_scheduled) {
latency->AddLatencyNumber(
ui::INPUT_EVENT_LATENCY_TERMINATED_MOUSE_COMPONENT, 0, 0);
- ComputeInputLatencyHistograms(WebInputEvent::MouseWheel,
- latency_component_id_, *latency);
}
+ ComputeInputLatencyHistograms(WebInputEvent::MouseWheel,
+ latency_component_id_, *latency);
return;
}

Powered by Google App Engine
This is Rietveld 408576698