Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: chrome/browser/sync/internal_api/sync_manager.h

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host.cc ('k') | chrome/browser/sync/internal_api/syncapi_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/internal_api/sync_manager.h
diff --git a/chrome/browser/sync/internal_api/sync_manager.h b/chrome/browser/sync/internal_api/sync_manager.h
index 3e75098382d2a569214aa08e11a2715d269a9fd1..bfc1736a5e89613fb62ae6e836d6956cc9600919 100644
--- a/chrome/browser/sync/internal_api/sync_manager.h
+++ b/chrome/browser/sync/internal_api/sync_manager.h
@@ -129,7 +129,8 @@ class SyncManager {
// The max number of consecutive errors from any component.
int max_consecutive_errors;
- browser_sync::SyncProtocolError sync_protocol_error;
+ // FIXME: is this used anywhere????
+ browser_sync::SyncOperationResult sync_protocol_error;
int unsynced_count;
@@ -381,7 +382,7 @@ class SyncManager {
const syncable::ModelTypeSet& encrypted_types) = 0;
virtual void OnActionableError(
- const browser_sync::SyncProtocolError& sync_protocol_error) = 0;
+ const browser_sync::SyncOperationResult& sync_operation_result) = 0;
protected:
virtual ~Observer();
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host.cc ('k') | chrome/browser/sync/internal_api/syncapi_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698