chrome/browser/sync/glue/sync_backend_host.cc - Issue 7861013: Fix the false-positive detection of commit errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/sync_backend_host.cc

Issue 7861013: Fix the false-positive detection of commit errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Another attempt at detecting errors Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/sync_backend_host.cc

diff --git a/chrome/browser/sync/glue/sync_backend_host.cc b/chrome/browser/sync/glue/sync_backend_host.cc

index be84a1ee1cfab4a94a4e2fafd33d7a4a6b3b9eb5..3de1f8fb89c54f56fd9ceb52df2a355e61ddd1ce 100644

--- a/chrome/browser/sync/glue/sync_backend_host.cc

+++ b/chrome/browser/sync/glue/sync_backend_host.cc

@@ -466,7 +466,7 @@ void SyncBackendHost::Core::OnEncryptionComplete(

}

void SyncBackendHost::Core::OnActionableError(

- const browser_sync::SyncProtocolError& sync_error) {

+ const browser_sync::SyncOperationResult& sync_error) {

if (!sync_loop_)

return;

DCHECK_EQ(MessageLoop::current(), sync_loop_);

@@ -683,7 +683,7 @@ void SyncBackendHost::Core::SaveChanges() {

}

void SyncBackendHost::Core::HandleActionableErrorEventOnFrontendLoop(

- const browser_sync::SyncProtocolError& sync_error) {

+ const browser_sync::SyncOperationResult& sync_error) {

if (!host_ || !host_->frontend_)

return;

DCHECK_EQ(MessageLoop::current(), host_->frontend_loop_);