Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 7860043: Merge r9213 into the 3.4 branch. (Closed)

Created:
9 years, 3 months ago by danno
Modified:
9 years, 3 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Merge r9213 into the 3.4 branch. This change fixes crashes caused by trying to change element property definitions, freeze, seal or preventExtensions on objects with external elements arrays. R=ricow@chromium.org BUG=95920 TEST=test/mjsunit/regress/regress-95920.js Committed: http://code.google.com/p/v8/source/detail?r=9234

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M src/messages.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-95920.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
PTAL
9 years, 3 months ago (2011-09-09 15:31:34 UTC) #1
Rico
LGTM
9 years, 3 months ago (2011-09-12 10:17:13 UTC) #2
Rico
9 years, 3 months ago (2011-09-12 10:19:22 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698