Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 785953004: Add histogram for "scan credit card" usage. (Closed)

Created:
6 years ago by Evan Stade
Modified:
5 years, 1 month ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add histogram for "scan credit card" usage. BUG=439252 Committed: https://crrev.com/a4f982f3230126573f795492de74227a128bcd0d Cr-Commit-Position: refs/heads/master@{#307958}

Patch Set 1 #

Patch Set 2 : merge #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -9 lines) Patch
M components/autofill/core/browser/autofill_external_delegate.h View 1 chunk +6 lines, -3 lines 2 comments Download
M components/autofill/core/browser/autofill_external_delegate.cc View 4 chunks +16 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_external_delegate_unittest.cc View 5 chunks +75 lines, -3 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
Evan Stade
6 years ago (2014-12-08 23:32:59 UTC) #2
please use gerrit instead
LGTM
6 years ago (2014-12-08 23:50:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785953004/1
6 years ago (2014-12-09 01:09:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/28995)
6 years ago (2014-12-09 01:14:36 UTC) #7
Evan Stade
+isherman for histograms.xml
6 years ago (2014-12-10 23:53:44 UTC) #9
Ilya Sherman
histograms lgtm, thanks.
6 years ago (2014-12-11 01:16:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785953004/1
6 years ago (2014-12-11 01:59:48 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/29617)
6 years ago (2014-12-11 02:06:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785953004/20001
6 years ago (2014-12-11 19:01:39 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-11 20:08:56 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/a4f982f3230126573f795492de74227a128bcd0d Cr-Commit-Position: refs/heads/master@{#307958}
6 years ago (2014-12-11 20:09:35 UTC) #18
Justin Donnelly
https://codereview.chromium.org/785953004/diff/20001/components/autofill/core/browser/autofill_external_delegate.h File components/autofill/core/browser/autofill_external_delegate.h (right): https://codereview.chromium.org/785953004/diff/20001/components/autofill/core/browser/autofill_external_delegate.h#newcode156 components/autofill/core/browser/autofill_external_delegate.h:156: // FIXME Just noticed this. I assume you meant ...
5 years, 1 month ago (2015-11-16 20:23:28 UTC) #20
Evan Stade
5 years, 1 month ago (2015-11-16 20:43:53 UTC) #21
Message was sent while issue was closed. 
https://codereview.chromium.org/785953004/diff/20001/components/autofill/core...
File components/autofill/core/browser/autofill_external_delegate.h (right):

https://codereview.chromium.org/785953004/diff/20001/components/autofill/core...
components/autofill/core/browser/autofill_external_delegate.h:156: // FIXME
On 2015/11/16 20:23:28, Justin Donnelly wrote:
> Just noticed this. I assume you meant to add a comment here?

oops. Yes, that was the intent.

Powered by Google App Engine
This is Rietveld 408576698