Add histogram for "scan credit card" usage.

components/autofill/core/browser/autofill_external_delegate_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/test/histogram_tester.h"
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/popup_item_ids.h"
 #include "components/autofill/core/browser/test_autofill_client.h"
 #include "components/autofill/core/browser/test_autofill_driver.h"
 #include "components/autofill/core/browser/test_autofill_external_delegate.h"
 #include "components/autofill/core/common/autofill_switches.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 56 matching lines @@
 };
 
 class MockAutofillManager : public AutofillManager {
  public:
   MockAutofillManager(AutofillDriver* driver, MockAutofillClient* client)
       // Force to use the constructor designated for unit test, but we don't
       // really need personal_data in this test so we pass a NULL pointer.
       : AutofillManager(driver, client, NULL) {}
   virtual ~MockAutofillManager() {}
 
+  MOCK_METHOD2(ShouldShowScanCreditCard,
+               bool(const FormData& form, const FormFieldData& field));
+
   MOCK_METHOD5(FillOrPreviewForm,
                void(AutofillDriver::RendererFormDataAction action,
                     int query_id,
                     const FormData& form,
                     const FormFieldData& field,
                     int unique_id));
 
   MOCK_METHOD4(FillCreditCardForm,
                void(int query_id,
                     const FormData& form,
                     const FormFieldData& field,
                     const CreditCard& credit_card));
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MockAutofillManager);
 };
 
 }  // namespace
 
 class AutofillExternalDelegateUnitTest : public testing::Test {
  protected:
   void SetUp() override {
-    autofill_driver_.reset(new MockAutofillDriver());
+    autofill_driver_.reset(new testing::NiceMock<MockAutofillDriver>());
     autofill_manager_.reset(
         new MockAutofillManager(autofill_driver_.get(), &autofill_client_));
     external_delegate_.reset(
         new AutofillExternalDelegate(
             autofill_manager_.get(), autofill_driver_.get()));
   }
 
   void TearDown() override {
     // Order of destruction is important as AutofillManager relies on
     // PersonalDataManager to be around when it gets destroyed.
     autofill_manager_.reset();
     external_delegate_.reset();
     autofill_driver_.reset();
   }
 
   // Issue an OnQuery call with the given |query_id|.
   void IssueOnQuery(int query_id) {
     const FormData form;
     FormFieldData field;
     field.is_focusable = true;
     field.should_autocomplete = true;
     const gfx::RectF element_bounds;
 
     external_delegate_->OnQuery(query_id, form, field, element_bounds, true);
   }
 
-  MockAutofillClient autofill_client_;
-  scoped_ptr<MockAutofillDriver> autofill_driver_;
+  void IssueOnSuggestionsReturned() {
+    std::vector<base::string16> autofill_item;
+    autofill_item.push_back(base::string16());
+    std::vector<int> autofill_ids;
+    autofill_ids.push_back(kAutofillProfileId);
+    external_delegate_->OnSuggestionsReturned(
+        kQueryId, autofill_item, autofill_item, autofill_item, autofill_ids);
+  }
+
+  testing::NiceMock<MockAutofillClient> autofill_client_;
+  scoped_ptr<testing::NiceMock<MockAutofillDriver>> autofill_driver_;
   scoped_ptr<MockAutofillManager> autofill_manager_;
   scoped_ptr<AutofillExternalDelegate> external_delegate_;
 
   base::MessageLoop message_loop_;
 };
 
 // Test that our external delegate called the virtual methods at the right time.
 TEST_F(AutofillExternalDelegateUnitTest, TestExternalDelegateVirtualCalls) {
   IssueOnQuery(kQueryId);
 
@@ skipping 291 matching lines @@
 
 // Test that autofill client will scan a credit card after use accepted the
 // suggestion to scan a credit card.
 TEST_F(AutofillExternalDelegateUnitTest, ScanCreditCardMenuItem) {
   EXPECT_CALL(autofill_client_, ScanCreditCard(_));
   EXPECT_CALL(autofill_client_, HideAutofillPopup());
   external_delegate_->DidAcceptSuggestion(base::string16(),
                                           POPUP_ITEM_ID_SCAN_CREDIT_CARD);
 }
 
+TEST_F(AutofillExternalDelegateUnitTest, ScanCreditCardPromptMetricsTest) {
+  // Log that the scan card item was shown, although nothing was selected.
+  {
+    EXPECT_CALL(*autofill_manager_, ShouldShowScanCreditCard(_, _))
+        .WillOnce(testing::Return(true));
+    base::HistogramTester histogram;
+    IssueOnQuery(kQueryId);
+    IssueOnSuggestionsReturned();
+    external_delegate_->OnPopupHidden();
+    histogram.ExpectUniqueSample("Autofill.ScanCreditCardPrompt",
+                                 AutofillMetrics::SCAN_CARD_ITEM_SHOWN, 1);
+  }
+  // Log that the scan card item was selected.
+  {
+    EXPECT_CALL(*autofill_manager_, ShouldShowScanCreditCard(_, _))
+        .WillOnce(testing::Return(true));
+    base::HistogramTester histogram;
+    IssueOnQuery(kQueryId);
+    IssueOnSuggestionsReturned();
+    external_delegate_->DidAcceptSuggestion(base::string16(),
+                                            POPUP_ITEM_ID_SCAN_CREDIT_CARD);
+    histogram.ExpectBucketCount("Autofill.ScanCreditCardPrompt",
+                                AutofillMetrics::SCAN_CARD_ITEM_SHOWN, 1);
+    histogram.ExpectBucketCount("Autofill.ScanCreditCardPrompt",
+                                AutofillMetrics::SCAN_CARD_ITEM_SELECTED, 1);
+    histogram.ExpectBucketCount("Autofill.ScanCreditCardPrompt",
+                                AutofillMetrics::SCAN_CARD_OTHER_ITEM_SELECTED,
+                                0);
+  }
+  // Log that something else was selected.
+  {
+    EXPECT_CALL(*autofill_manager_, ShouldShowScanCreditCard(_, _))
+        .WillOnce(testing::Return(true));
+    base::HistogramTester histogram;
+    IssueOnQuery(kQueryId);
+    IssueOnSuggestionsReturned();
+    external_delegate_->DidAcceptSuggestion(base::string16(),
+                                            POPUP_ITEM_ID_CLEAR_FORM);
+    histogram.ExpectBucketCount("Autofill.ScanCreditCardPrompt",
+                                AutofillMetrics::SCAN_CARD_ITEM_SHOWN, 1);
+    histogram.ExpectBucketCount("Autofill.ScanCreditCardPrompt",
+                                AutofillMetrics::SCAN_CARD_ITEM_SELECTED, 0);
+    histogram.ExpectBucketCount("Autofill.ScanCreditCardPrompt",
+                                AutofillMetrics::SCAN_CARD_OTHER_ITEM_SELECTED,
+                                1);
+  }
+  // Nothing is logged when the item isn't shown.
+  {
+    EXPECT_CALL(*autofill_manager_, ShouldShowScanCreditCard(_, _))
+        .WillOnce(testing::Return(false));
+    base::HistogramTester histogram;
+    IssueOnQuery(kQueryId);
+    IssueOnSuggestionsReturned();
+    external_delegate_->DidAcceptSuggestion(base::string16(),
+                                            POPUP_ITEM_ID_CLEAR_FORM);
+    histogram.ExpectTotalCount("Autofill.ScanCreditCardPrompt", 0);
+  }
+}
+
 // Test that autofill manager will fill the credit card form after user scans a
 // credit card.
 TEST_F(AutofillExternalDelegateUnitTest, FillCreditCardForm) {
   base::string16 card_number = base::ASCIIToUTF16("test");
   int expiration_month = 1;
   int expiration_year = 3000;
   EXPECT_CALL(
       *autofill_manager_,
       FillCreditCardForm(
           _, _, _, CreditCard(card_number, expiration_month, expiration_year)));
@@ skipping 58 matching lines @@
 TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateFillFieldWithValue) {
   EXPECT_CALL(autofill_client_, HideAutofillPopup());
   base::string16 dummy_string(ASCIIToUTF16("baz foo"));
   EXPECT_CALL(*autofill_driver_,
               RendererShouldFillFieldWithValue(dummy_string));
   external_delegate_->DidAcceptSuggestion(dummy_string,
                                           POPUP_ITEM_ID_AUTOCOMPLETE_ENTRY);
 }
 
 }  // namespace autofill