Issue 785823002: use factory for colorshader, class is deprecated

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 785823002: use factory for colorshader, class is deprecated (Closed)

Created:
6 years ago by reed2

Modified:
6 years ago

Reviewers:
pdr., f(malita)

CC:
blink-reviews, Dominik Röttsches, krit, Rik, jbroman, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

use factory for colorshader, class is deprecated BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186698

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -6 lines)			Patch
M	Source/platform/graphics/BitmapPattern.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/platform/graphics/Gradient.cpp	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	Source/platform/graphics/StaticBitmapPattern.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

pdr.

On 2014/12/07 at 20:47:39, reed wrote: > will remove from skia asap LGTM

6 years ago (2014-12-07 21:47:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785823002/20001

6 years ago (2014-12-08 12:09:47 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-08 13:16:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186698