Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 7858035: Fix bogus reset of store buffer top in deserializer. (Closed)

Created:
9 years, 3 months ago by Michael Starzinger
Modified:
9 years, 3 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix bogus reset of store buffer top in deserializer. This was originally introduced in r6201 because the store buffer top is part of the root set and treated as SMI, which in turn causes it to be overwritten by the deserializer. A better fix was introduced in r6443 and skips the entry instead of restoring it after deserialization, thus making this reset obsolete. R=erik.corry@gmail.com BUG=v8:1562 Committed: http://code.google.com/p/v8/source/detail?r=9221

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/serialize.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Starzinger
PTAL.
9 years, 3 months ago (2011-09-09 16:42:47 UTC) #1
Erik Corry
9 years, 3 months ago (2011-09-12 07:14:58 UTC) #2
LGTM.  Thanks for figuring this out.

Powered by Google App Engine
This is Rietveld 408576698