Issue 7857014: patch for global error bubbles (view/gtk)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7857014: patch for global error bubbles (view/gtk) (Closed)

Created:
9 years, 3 months ago by sail

Modified:
9 years, 3 months ago

Reviewers:

CC:
chromium-reviews, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

patch for global error bubbles (view/gtk) BUG= TEST=

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2447 lines, -9 lines)			Patch
A	chrome/app/nibs/GlobalErrorBubble.xib	View	1 chunk	+1506 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_init.cc	View	3 chunks	+51 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/global_error_bubble_controller.h	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/cocoa/global_error_bubble_controller.mm	View	1 chunk	+103 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/l10n_util.mm	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/toolbar/toolbar_controller.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm	View	4 chunks	+29 lines, -2 lines	0 comments	Download
A	chrome/browser/ui/global_error_bubble_view.h	View	1 chunk	+21 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/global_error_delegate.h	View	1 chunk	+50 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/global_error_delegate.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/global_error_service.h	View	1 chunk	+41 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/global_error_service.cc	View	1 chunk	+31 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/global_error_service_factory.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/global_error_service_factory.cc	View	1 chunk	+36 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/browser_toolbar_gtk.cc	View	2 chunks	+21 lines, -5 lines	0 comments	Download
A	chrome/browser/ui/gtk/global_error_bubble.h	View	1 chunk	+37 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/gtk/global_error_bubble.cc	View	1 chunk	+149 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/toolbar/wrench_menu_model.cc	View	6 chunks	+46 lines, -1 line	0 comments	Download
A	chrome/browser/ui/views/global_error_bubble_view.h	View	1 chunk	+41 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/global_error_bubble_view.cc	View	1 chunk	+149 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	3 chunks	+20 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View	6 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/chrome_dll.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download