Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 785643002: Pass mojo::MediaRendererPtr in MojoRendererImpl's constructor. (Closed)

Created:
6 years ago by xhwang
Modified:
6 years ago
Reviewers:
jamesr
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@media_app
Project:
chromium
Visibility:
Public.

Description

Pass mojo::MediaRendererPtr in MojoRendererImpl's constructor. BUG=416570 TEST=Existing tests pass. Committed: https://crrev.com/8d5642a7521dc0440435ede181f87ff95dd9c97d Cr-Commit-Position: refs/heads/master@{#307121}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase only #

Patch Set 3 : comments addressed #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M media/mojo/services/media_renderer_apptest.cc View 1 3 chunks +9 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.h View 2 chunks +2 lines, -7 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.cc View 1 2 3 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
xhwang
A simple CL to address a comment we discussed before. PTAL, thanks!
6 years ago (2014-12-05 22:32:57 UTC) #2
jamesr
lgtm https://codereview.chromium.org/785643002/diff/1/mojo/services/html_viewer/webmediaplayer_factory.cc File mojo/services/html_viewer/webmediaplayer_factory.cc (right): https://codereview.chromium.org/785643002/diff/1/mojo/services/html_viewer/webmediaplayer_factory.cc#newcode64 mojo/services/html_viewer/webmediaplayer_factory.cc:64: mojo::MediaRendererPtr mojo_media_renderer; we're in namespace mojo here, so ...
6 years ago (2014-12-05 23:12:31 UTC) #3
xhwang
https://codereview.chromium.org/785643002/diff/1/mojo/services/html_viewer/webmediaplayer_factory.cc File mojo/services/html_viewer/webmediaplayer_factory.cc (right): https://codereview.chromium.org/785643002/diff/1/mojo/services/html_viewer/webmediaplayer_factory.cc#newcode64 mojo/services/html_viewer/webmediaplayer_factory.cc:64: mojo::MediaRendererPtr mojo_media_renderer; On 2014/12/05 23:12:31, jamesr wrote: > we're ...
6 years ago (2014-12-05 23:31:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785643002/40001
6 years ago (2014-12-05 23:31:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/40397)
6 years ago (2014-12-05 23:42:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785643002/60001
6 years ago (2014-12-05 23:51:15 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-06 00:29:14 UTC) #11
commit-bot: I haz the power
6 years ago (2014-12-06 00:30:20 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8d5642a7521dc0440435ede181f87ff95dd9c97d
Cr-Commit-Position: refs/heads/master@{#307121}

Powered by Google App Engine
This is Rietveld 408576698