Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: mojo/services/html_viewer/webmediaplayer_factory.cc

Issue 785643002: Pass mojo::MediaRendererPtr in MojoRendererImpl's constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@media_app
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_renderer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/html_viewer/webmediaplayer_factory.cc
diff --git a/mojo/services/html_viewer/webmediaplayer_factory.cc b/mojo/services/html_viewer/webmediaplayer_factory.cc
index ba11f2da3dd682227aff60987cfc5c1dac5fd8fc..15b6177b87b2d66efed8d100673e36c07a5bb097 100644
--- a/mojo/services/html_viewer/webmediaplayer_factory.cc
+++ b/mojo/services/html_viewer/webmediaplayer_factory.cc
@@ -18,7 +18,9 @@
#include "media/blink/webmediaplayer_impl.h"
#include "media/blink/webmediaplayer_params.h"
#include "media/filters/gpu_video_accelerator_factories.h"
+#include "media/mojo/interfaces/media_renderer.mojom.h"
#include "media/mojo/services/mojo_renderer_impl.h"
+#include "mojo/public/cpp/application/connect.h"
#include "mojo/public/interfaces/application/shell.mojom.h"
namespace mojo {
@@ -59,8 +61,13 @@ blink::WebMediaPlayer* WebMediaPlayerFactory::CreateMediaPlayer(
ServiceProviderPtr media_renderer_service_provider;
shell->ConnectToApplication("mojo:media",
GetProxy(&media_renderer_service_provider));
- renderer.reset(new media::MojoRendererImpl(
- GetMediaThreadTaskRunner(), media_renderer_service_provider.get()));
+
+ MediaRendererPtr mojo_media_renderer;
+ ConnectToService(media_renderer_service_provider.get(),
+ &mojo_media_renderer);
+
+ renderer.reset(new media::MojoRendererImpl(GetMediaThreadTaskRunner(),
+ mojo_media_renderer.Pass()));
}
media::WebMediaPlayerParams params(
« no previous file with comments | « media/mojo/services/mojo_renderer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698