Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 785393002: Revert "Roll Clang 218707:223109 (+r223211, +r223219, -r220714)" and follow-ups. (Closed)

Created:
6 years ago by hans
Modified:
6 years ago
Reviewers:
Nico
CC:
chromium-reviews, eugenis+clang_chromium.org, grt+watch_chromium.org, glider+clang_chromium.org, ukai+watch_chromium.org, wfh+watch_chromium.org, dmikurube+clang_chromium.org, Michael Moss
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Roll Clang 218707:223109 (+r223211, +r223219, -r220714)" and follow-ups. It was causing strange test failures in Mac ASan builds. BUG=431803, 440602 NOTRY=true TBR=thakis Committed: https://crrev.com/d43941e4aca78576419b8ca2d74a416b4af17d84 Cr-Commit-Position: refs/heads/master@{#307594}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -159 lines) Patch
M build/common.gypi View 4 chunks +12 lines, -5 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M build/sanitizers/sanitizer_options.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/linux/debian/expected_deps_x64 View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_i386 View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/rpm/expected_deps_x86_64 View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/CMakeLists.txt View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/plugins/tests/overridden_methods.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M tools/clang/plugins/tests/test.sh View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/scripts/package.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/repackage.sh View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/scripts/update.sh View 3 chunks +159 lines, -130 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785393002/1
6 years ago (2014-12-10 00:24:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-10 00:25:13 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-10 00:26:14 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d43941e4aca78576419b8ca2d74a416b4af17d84
Cr-Commit-Position: refs/heads/master@{#307594}

Powered by Google App Engine
This is Rietveld 408576698