Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: tools/clang/plugins/tests/overridden_methods.txt

Issue 785393002: Revert "Roll Clang 218707:223109 (+r223211, +r223219, -r220714)" and follow-ups. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/clang/blink_gc_plugin/CMakeLists.txt ('k') | tools/clang/plugins/tests/test.sh » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 In file included from overridden_methods.cpp:5: 1 In file included from overridden_methods.cpp:5:
2 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 2 ./overridden_methods.h:48:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
3 virtual void SomeMethod(); 3 virtual void SomeMethod();
4 ^ 4 ^
5 override 5 override
6 ./overridden_methods.h:52:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 6 ./overridden_methods.h:52:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
7 virtual void SomeInlineMethod() {} 7 virtual void SomeInlineMethod() {}
8 ^ 8 ^
9 override 9 override
10 ./overridden_methods.h:56:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 10 ./overridden_methods.h:56:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
11 virtual void SomeConstMethod() const {} 11 virtual void SomeConstMethod() const {}
12 ^ 12 ^
13 override 13 override
14 ./overridden_methods.h:58:55: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 14 ./overridden_methods.h:58:53: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
15 virtual void SomeMethodWithExceptionSpec() throw() {} 15 virtual void SomeMethodWithExceptionSpec() throw() {}
16 ^ 16 ^
17 override 17 override
18 ./overridden_methods.h:61:69: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 18 ./overridden_methods.h:61:67: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
19 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {} 19 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {}
20 ^ 20 ^
21 override 21 override
22 ./overridden_methods.h:63:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 22 ./overridden_methods.h:63:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
23 virtual void SomeNonPureBaseMethod() {} 23 virtual void SomeNonPureBaseMethod() {}
24 ^ 24 ^
25 override 25 override
26 ./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 26 ./overridden_methods.h:65:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
27 virtual void SomeMethodWithComment(); // This is a comment. 27 virtual void SomeMethodWithComment(); // This is a comment.
28 ^ 28 ^
29 override 29 override
30 ./overridden_methods.h:67:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 30 ./overridden_methods.h:67:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
31 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 31 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
32 ^ 32 ^
33 override 33 override
34 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 34 overridden_methods.cpp:24:28: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
35 virtual void SomeMethod(); 35 virtual void SomeMethod();
36 ^ 36 ^
37 override 37 override
38 overridden_methods.cpp:28:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 38 overridden_methods.cpp:28:34: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
39 virtual void SomeInlineMethod() {} 39 virtual void SomeInlineMethod() {}
40 ^ 40 ^
41 override 41 override
42 overridden_methods.cpp:32:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 42 overridden_methods.cpp:32:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
43 virtual void SomeConstMethod() const {} 43 virtual void SomeConstMethod() const {}
44 ^ 44 ^
45 override 45 override
46 overridden_methods.cpp:34:55: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 46 overridden_methods.cpp:34:53: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
47 virtual void SomeMethodWithExceptionSpec() throw() {} 47 virtual void SomeMethodWithExceptionSpec() throw() {}
48 ^ 48 ^
49 override 49 override
50 overridden_methods.cpp:37:69: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 50 overridden_methods.cpp:37:67: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
51 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {} 51 virtual void SomeConstMethodWithExceptionSpec() const throw(int) {}
52 ^ 52 ^
53 override 53 override
54 overridden_methods.cpp:39:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 54 overridden_methods.cpp:39:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
55 virtual void SomeNonPureBaseMethod() {} 55 virtual void SomeNonPureBaseMethod() {}
56 ^ 56 ^
57 override 57 override
58 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 58 overridden_methods.cpp:41:39: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
59 virtual void SomeMethodWithComment(); // This is a comment. 59 virtual void SomeMethodWithComment(); // This is a comment.
60 ^ 60 ^
61 override 61 override
62 overridden_methods.cpp:43:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'. 62 overridden_methods.cpp:43:46: warning: [chromium-style] Overriding method must b e marked with 'override' or 'final'.
63 virtual void SomeMethodWithCommentAndBody() {} // This is a comment. 63 virtual void SomeMethodWithCommentAndBody() {} // This is a comment.
64 ^ 64 ^
65 override 65 override
66 16 warnings generated. 66 16 warnings generated.
OLDNEW
« no previous file with comments | « tools/clang/blink_gc_plugin/CMakeLists.txt ('k') | tools/clang/plugins/tests/test.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698