Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 785373002: Update browser/first_run to use the new version of LaunchProcess. (Closed)

Created:
6 years ago by rvargas (doing something else)
Modified:
6 years ago
Reviewers:
gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update browser/first_run to use the new version of LaunchProcess. BUG=417532 Committed: https://crrev.com/2d12a462d60008756082f1af2f8c36e0f9b31ff5 Cr-Commit-Position: refs/heads/master@{#308369}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/first_run/first_run_internal_win.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 8 (2 generated)
rvargas (doing something else)
6 years ago (2014-12-12 20:59:23 UTC) #2
rvargas (doing something else)
(please check the CQ if you're happy)
6 years ago (2014-12-14 07:21:51 UTC) #3
gab
lgtm w/ nit https://codereview.chromium.org/785373002/diff/1/chrome/browser/first_run/upgrade_util_win.cc File chrome/browser/first_run/upgrade_util_win.cc (right): https://codereview.chromium.org/785373002/diff/1/chrome/browser/first_run/upgrade_util_win.cc#newcode161 chrome/browser/first_run/upgrade_util_win.cc:161: return base::LaunchProcess(chrome_exe_command_line, nit: This should be ...
6 years ago (2014-12-15 15:56:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785373002/1
6 years ago (2014-12-15 15:56:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-15 17:57:21 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-15 17:58:05 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d12a462d60008756082f1af2f8c36e0f9b31ff5
Cr-Commit-Position: refs/heads/master@{#308369}

Powered by Google App Engine
This is Rietveld 408576698