Update browser/first_run to use the new version of LaunchProcess.

chrome/browser/first_run/upgrade_util_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/first_run/upgrade_util.h"
 
 #include <windows.h>
 #include <psapi.h>
 #include <shellapi.h>
 
@@ skipping 140 matching lines @@
 
   // Explicitly make sure to relaunch chrome.exe rather than old_chrome.exe.
   // This can happen when old_chrome.exe is launched by a user.
   CommandLine chrome_exe_command_line = command_line;
   chrome_exe_command_line.SetProgram(
       chrome_exe.DirName().Append(installer::kChromeExe));
 
   if (base::win::GetVersion() < base::win::VERSION_WIN8 &&
       relaunch_mode != RELAUNCH_MODE_METRO &&
       relaunch_mode != RELAUNCH_MODE_DESKTOP)
     return base::LaunchProcess(chrome_exe_command_line,

[gab, 2014/12/15 15:56:14]

nit: This should be wrapped in {} since condition/body are multi-line.

(but since this was already a problem with the old code and this is not making
it worse I'll CQ anyways)

-                               base::LaunchOptions(), NULL);
+                               base::LaunchOptions()).IsValid();
 
   // On Windows 8 we always use the delegate_execute for re-launching chrome.
   // On Windows 7 we use delegate_execute for re-launching chrome into Windows
   // ASH.
   //
   // Pass this Chrome's Start Menu shortcut path to the relauncher so it can re-
   // activate chrome via ShellExecute which will wait until we exit. Since
   // ShellExecute does not support handle passing to the child process we create
   // a uniquely named mutex that we aquire and never release. So when we exit,
   // Windows marks our mutex as abandoned and the wait is satisfied. The format
@@ skipping 130 matching lines @@
     return false;
   // At this point the chrome.exe has been swapped with the new one.
   if (!RelaunchChromeBrowser(command_line)) {
     // The re-launch fails. Feel free to panic now.
     NOTREACHED();
   }
   return true;
 }
 
 }  // namespace upgrade_util