Issue 785253002: Revert of Do not embed constant functions in StoreTransition stub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 785253002: Revert of Do not embed constant functions in StoreTransition stub. (Closed)

Created:
6 years ago by Yang

Modified:
6 years ago

Reviewers:
Igor Sheludko, ulan, ishell

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

Revert of Do not embed constant functions in StoreTransition stub. (patchset #3 id:40001 of https://codereview.chromium.org/769733003/) Reason for revert: GC stress failure: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress%20-%201/builds/1038 Original issue's description: > Do not embed constant functions in StoreTransition stub. > > BUG=v8:3629 > LOG=N TBR=ishell@google.com,ishell@chromium.org,ulan@chromium.org NOTREECHECKS=true NOTRY=true BUG=v8:3629

Created: 6 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -76 lines)			Patch
M	src/ic/arm/handler-compiler-arm.cc	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	src/ic/arm64/handler-compiler-arm64.cc	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	src/ic/handler-compiler.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/ic/handler-compiler.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/ic/ia32/handler-compiler-ia32.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	src/ic/mips/handler-compiler-mips.cc	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	src/ic/mips64/handler-compiler-mips64.cc	View	1 chunk	+3 lines, -10 lines	0 comments	Download
M	src/ic/x64/handler-compiler-x64.cc	View	1 chunk	+2 lines, -11 lines	0 comments	Download
M	src/ic/x87/handler-compiler-x87.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

Created Revert of Do not embed constant functions in StoreTransition stub.

6 years ago (2014-12-09 16:08:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/785253002/1

6 years ago (2014-12-09 16:09:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1)