Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Side by Side Diff: src/ic/arm/handler-compiler-arm.cc

Issue 785253002: Revert of Do not embed constant functions in StoreTransition stub. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 318 matching lines...) Expand 10 before | Expand all | Expand 10 after
329 DCHECK(!map_reg.is(scratch)); 329 DCHECK(!map_reg.is(scratch));
330 __ LoadWeakValue(map_reg, cell, miss); 330 __ LoadWeakValue(map_reg, cell, miss);
331 if (transition->CanBeDeprecated()) { 331 if (transition->CanBeDeprecated()) {
332 __ ldr(scratch, FieldMemOperand(map_reg, Map::kBitField3Offset)); 332 __ ldr(scratch, FieldMemOperand(map_reg, Map::kBitField3Offset));
333 __ tst(scratch, Operand(Map::Deprecated::kMask)); 333 __ tst(scratch, Operand(Map::Deprecated::kMask));
334 __ b(ne, miss); 334 __ b(ne, miss);
335 } 335 }
336 } 336 }
337 337
338 338
339 void NamedStoreHandlerCompiler::GenerateConstantCheck(Register map_reg, 339 void NamedStoreHandlerCompiler::GenerateConstantCheck(Object* constant,
340 int descriptor,
341 Register value_reg, 340 Register value_reg,
342 Register scratch,
343 Label* miss_label) { 341 Label* miss_label) {
344 DCHECK(!map_reg.is(scratch)); 342 __ Move(scratch1(), handle(constant, isolate()));
345 DCHECK(!map_reg.is(value_reg)); 343 __ cmp(value_reg, scratch1());
346 DCHECK(!value_reg.is(scratch));
347 __ LoadInstanceDescriptors(map_reg, scratch);
348 __ ldr(scratch,
349 FieldMemOperand(scratch, DescriptorArray::GetValueOffset(descriptor)));
350 __ cmp(value_reg, scratch);
351 __ b(ne, miss_label); 344 __ b(ne, miss_label);
352 } 345 }
353 346
354 347
355 void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(HeapType* field_type, 348 void NamedStoreHandlerCompiler::GenerateFieldTypeChecks(HeapType* field_type,
356 Register value_reg, 349 Register value_reg,
357 Label* miss_label) { 350 Label* miss_label) {
358 __ JumpIfSmi(value_reg, miss_label); 351 __ JumpIfSmi(value_reg, miss_label);
359 HeapType::Iterator<Map> it = field_type->Classes(); 352 HeapType::Iterator<Map> it = field_type->Classes();
360 if (!it.Done()) { 353 if (!it.Done()) {
(...skipping 331 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 // Return the generated code. 685 // Return the generated code.
693 return GetCode(kind(), Code::NORMAL, name); 686 return GetCode(kind(), Code::NORMAL, name);
694 } 687 }
695 688
696 689
697 #undef __ 690 #undef __
698 } 691 }
699 } // namespace v8::internal 692 } // namespace v8::internal
700 693
701 #endif // V8_TARGET_ARCH_ARM 694 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698